Review Request: Add Category and NewGame classes
Shantanu Tushar Jha
jhahoneyk at gmail.com
Mon Jul 4 09:31:03 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/
-----------------------------------------------------------
(Updated July 4, 2011, 7:31 a.m.)
Review request for Gluon.
Changes
-------
Updated Patch with NewGameJob and CategoryListJob. Header declaration order is as Arjen suggested.
Fixed code according to Laszlo's comments, better names for signals; declarations are still on same line, I think its better if we make it standard in gluon.
(Note: EditGame is not there in the patch, I'm trying to keep two classes per review).
Summary
-------
Category's job is to fetch list of categories from the server.
NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
Diffs (updated)
-----
player/lib/CMakeLists.txt 53c0f0a
player/lib/categorylistjob.h PRE-CREATION
player/lib/categorylistjob.cpp PRE-CREATION
player/lib/newgamejob.h PRE-CREATION
player/lib/newgamejob.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101816/diff
Testing
-------
Both classes function as expected when used.
Thanks,
Shantanu Tushar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110704/1b8f543a/attachment.htm
More information about the Gluon
mailing list