Review Request: Add Category and NewGame classes

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101816/#review4348
-----------------------------------------------------------



player/lib/category.h
<http://git.reviewboard.kde.org/r/101816/#comment3643>

    Actually, there is an interesting language mixup happening here. The name "Category" implies that it is singular, i.e. it encapsulates a single item. However, the methods then refer to multiples, which makes it somewhat confusing. I would recommend changing the classname to something like "CategoryList" and then removing all the "Categories" from the method names.
    
    You might even want to change the API a bit, to make this an actual QList subclass instead of needing to work with two separate objects.


- Arjen


On July 2, 2011, 2:29 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101816/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 2:29 p.m.)
> 
> 
> Review request for Gluon.
> 
> 
> Summary
> -------
> 
> Category's job is to fetch list of categories from the server.
> NewGame takes a game name and a category, and then creates a new game on the server, returning the ID of newly created game.
> 
> 
> Diffs
> -----
> 
>   player/lib/CMakeLists.txt 53c0f0a 
>   player/lib/category.h PRE-CREATION 
>   player/lib/category.cpp PRE-CREATION 
>   player/lib/remotegame.h PRE-CREATION 
>   player/lib/remotegame.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101816/diff
> 
> 
> Testing
> -------
> 
> Both classes function as expected when used.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/gluon/attachments/20110703/915a85e9/attachment.htm