Review Request: Proposal how to fix a problem I have with ObjectTreeBuilder

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103464/#review9374
-----------------------------------------------------------



core/gdl/objecttreebuilder.cpp
<http://git.reviewboard.kde.org/r/103464/#comment7731>

    Hmm, I think it works better to make this a three-step process. So first check to see whether it is a relative path and if so, resolve that. If not, check against the object and finally check against the project. Checking whether it is a relative path also needs a better condition than whether or not the parent is set, as they are not mutually exclusive.



core/gdlserializer.h
<http://git.reviewboard.kde.org/r/103464/#comment7730>

    I would prefer it if you just called it parent everywhere, adding the gdl in front of it makes it feel rather ugly.



engine/assets/other/achievements/achievementsasset.cpp
<http://git.reviewboard.kde.org/r/103464/#comment7732>

    Why the cast? "this" will always be an AchievementAsset so it will be optimised away anyway.



engine/assets/other/statistics/statisticsasset.cpp
<http://git.reviewboard.kde.org/r/103464/#comment7733>

    See the comment on AchievementAsset.


- Arjen Hiemstra


On Dec. 28, 2011, 6:24 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103464/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2011, 6:24 p.m.)
> 
> 
> Review request for Gluon and Arjen Hiemstra.
> 
> 
> Description
> -------
> 
> I added a parameter for the gdl file parent, which is used to create relative paths.
> 
> 
> Diffs
> -----
> 
>   core/gdl/objecttreebuilder.h 4c51c9b 
>   core/gdl/objecttreebuilder.cpp 4dcefa8 
>   core/gdlserializer.h e88f179 
>   core/gdlserializer.cpp 7b27874 
>   engine/assets/other/achievements/achievementsasset.cpp 3c4937b 
>   engine/assets/other/statistics/statisticsasset.cpp a78a67e 
> 
> Diff: http://git.reviewboard.kde.org/r/103464/diff/diff
> 
> 
> Testing
> -------
> 
> - My problem is solved
> - Invaders still loads into creator and can be played.
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111230/bc9640e5/attachment.html>