Review Request: Proposal how to fix a problem I have with ObjectTreeBuilder

Felix Rohrbach fxrh at gmx.de
Wed Dec 28 18:24:44 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103464/
-----------------------------------------------------------

(Updated Dec. 28, 2011, 6:24 p.m.)


Review request for Gluon and Arjen Hiemstra.


Changes
-------

Next try :) What do you think of this?


Description (updated)
-------

I added a parameter for the gdl file parent, which is used to create relative paths.


Diffs (updated)
-----

  core/gdl/objecttreebuilder.h 4c51c9b 
  core/gdl/objecttreebuilder.cpp 4dcefa8 
  core/gdlserializer.h e88f179 
  core/gdlserializer.cpp 7b27874 
  engine/assets/other/achievements/achievementsasset.cpp 3c4937b 
  engine/assets/other/statistics/statisticsasset.cpp a78a67e 

Diff: http://git.reviewboard.kde.org/r/103464/diff/diff


Testing
-------

- My problem is solved
- Invaders still loads into creator and can be played.


Thanks,

Felix Rohrbach

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gluon/attachments/20111228/c52d5aa7/attachment.html>


More information about the Gluon mailing list