Railroad review

[JAZEIX Johnny]

Hi,

for me the timer has no plus-value (except potentially stress children 
if they don't manage to memorize in time) so I would remove it.

I would also change the reload button to the hint button that would 
display the locomotives again (instead of removing everything) and 
potentially hiding all the locomotives below while it's on hint mode.

You can probably add one step in the introduction to tell the child to 
drag and drop the wagons on top.

I find a little confusing having the drag/drop and swiping with the same 
command (basically, swiping if you select and go left/right and drag 
item if going top or bottom?). Maybe if the flows were top to bottom 
(meaning more rows, all the wagons in one row being always displayed) 
with a vertical scrollbar on the side, it would be better? What do you 
think?

I think resource/bg.svg is not used.

Except these points the logic is good for me, I'll check the code later.

Johnny

On 03/05/17 14:55, Utkarsh Tiwari wrote:
> Hi,
>     Here is the updated Revision for the Railroad activity - 
> https://phabricator.kde.org/D4014
>
> Improvements:
>
>  1. Drag/drop improved for top and lower section
>  2. Timer added to let player have time to memorize and do swipe view
>     before the train vanishes
>  3. Intro message changed
>  4. Swipe area provide in the top carriages section for user to view
>     hidden ones in portrait mode
>
>
> Please test it and share your reviews
>
> Regards,
> Utkarsh Tiwari
>
> On Thu, 2 Mar 2017 at 17:00 Utkarsh Tiwari <iamutkarshtiwari at gmail.com 
> <mailto:iamutkarshtiwari at gmail.com>> wrote:
>
>     Sorry, the gif didn't upload properly. New link -
>     http://imgur.com/a/v4KgR
>
>     Regards,
>     Utkarsh
>
>     On Thu, 2 Mar 2017 at 16:51 Utkarsh Tiwari
>     <iamutkarshtiwari at gmail.com <mailto:iamutkarshtiwari at gmail.com>>
>     wrote:
>
>         Hi,
>             The problem is now resolved (gif- http://imgur.com/a/yBTEJ
>         ) Thanks :)
>
>         Regards,
>         Utkarsh Tiwari
>
>         On Thu, 2 Mar 2017 at 16:24 JAZEIX Johnny <jazeix at gmail.com
>         <mailto:jazeix at gmail.com>> wrote:
>
>             Hi,
>
>             Divyam is actually doing something similar to add a
>             scrollbar on categorisation_words.
>
>             It can be an idea to have a visible scrollbar on the side
>             and instead of having horizontal flows, having vertical ones.
>
>
>             Johnny
>
>
>             On 02/28/17 20:59, Utkarsh Tiwari wrote:
>>             Hi,
>>                 While trying to implement the drag/drop functionality
>>             in Railroad activity I found out that the Flow feature
>>             fails to work while draggin dropping the item. I am
>>             unable to view the hidden carriages which are outside the
>>             display area since Flow fails to work.
>>
>>             Any suggestions on how to make use of both Flow and
>>             drag/drop or shall I remove Flow functionality from the Rows?
>>
>>             Gif link - https://gifyu.com/image/SjjJ
>>
>>             Regards,
>>             Utkarsh Tiwari
>>
>>             On Fri, 3 Feb 2017 at 23:40 Utkarsh Tiwari
>>             <iamutkarshtiwari at gmail.com
>>             <mailto:iamutkarshtiwari at gmail.com>> wrote:
>>
>>                 Hi,
>>                     Here is the link to the updated diff -
>>                 https://phabricator.kde.org/D4014 Please test it and
>>                 share your reviews.
>>
>>                 Regards,
>>                 Utkarsh
>>
>>                 On Wed, 1 Feb 2017 at 19:11 Utkarsh Tiwari
>>                 <iamutkarshtiwari at gmail.com
>>                 <mailto:iamutkarshtiwari at gmail.com>> wrote:
>>
>>                     Hi,
>>                          Here is the updated diff for the latest
>>                     Railroad code -
>>                     https://phabricator.kde.org/D4014 Please review
>>                     and share your suggestions.
>>
>>                     Regards,
>>                     Utkarsh Tiwari
>>
>>             -- 
>>             Regards,
>>             Utkarsh Tiwari
>
>
>         -- 
>         Regards,
>         Utkarsh Tiwari
>
>     -- 
>     Regards,
>     Utkarsh Tiwari
>
> -- 
> Regards,
> Utkarsh Tiwari


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/gcompris-devel/attachments/20170308/95b823e3/attachment.html>