[gcompris-devel] More music activity comments, based on git commit 672eb8eecd 12.09.2012

[Bruno Coudoin]

Le vendredi 14 septembre 2012 à 01:30 -0400, Beth Hadley a écrit :
> Grr...git is still not my friend. I'm trying to merge and update my
> current repo but I'm getting tons of merge errors, etc. Until I have
> some time to really dig in and fix that, I just pulled Bruno's master
> and ran the current code to investigate your latest comments. Here are
> my thoughts (although brief! sorry!)

Perhaps something like this would do it:
git checkout bethmaster
git merge -s recursive -X theirs brunomaster

> > > Level 2:
> > >
> > > Guessing an animal sound correctly, will display a bonus.
> > > But the bonus sound is only played ~200 milliseconds before
> > > the next animal sound is played.
> > > Looking at the code, in checkAnswer() there is:
> > > > gcompris.bonus.display(gcompris.bonus.WIN, gcompris.bonus.SMILEY)
> > > > self.playRandom()
> >
> > Hum, I made a fix in this spirit but I have not tested with the bonus
> > sound.
> >
> I noticed this is a problem as well. With the new version of explore
> activity, the bonus is displayed, and simultaneously a new sound is
> played. I suggest adding back in the delay that waited to play the new
> sound until after the bonus disappears.

Arf, I made a fix, I was not testing for pause end to call the next
sound.

> > > ** Play Piano
> > >
> > > The rubber showing only if notes have been played, works
> > > well. And the new note bonus is very nice. ;)
> I agree. Excellent improvements Bruno!
> > I reworked this one again even more. Now I removed the need to have an
> > OK button. I mark the notes as passed or failed in real time.
> 
> > Sadly, Beth did the staff too small and scale it it thus the image
> > quality of my status mark are ugly.
> Bruno, I really like your idea here but the check status pictures are
> way too ugly. I made the piano staff small then scaled it so that I
> could reuse the same code for multiple activities, each requiring a
> different size musical staff. So I'm wondering if you can just load in
> larger images and scale these accordingly.

Beth, I should have given more explanation here. Using the scaling
feature was a good idea but not in this direction. When you are doing
graphics, you always loose details when you scale up (well except in
hollywood movies). The good approach here is to make the 1 ratio version
of the staff that uses the whole GCompris's screen. Then in each
activity you set a scale to 0.5 or something to make it smaller.

> Also, another thing I noticed: the lyrics for the activity extend on
> top of the music staff. Not good. Bruno, I think you went in and
> changed some formatting,  so you'll want to look at that and make sure
> it all fits nicely in the space provided. It's not a huge space, but
> it's plenty of room for  a couple lines of lyrics.

Yes, this is on my TODO list to rework this activity layout to have room
for everything.

Bruno.