[gcompris-devel] Learning Braille Activity
Bruno Coudoin
bruno.coudoin at gcompris.net
Sat May 14 22:14:39 UTC 2011
Le samedi 14 mai 2011 à 23:51 +0530, srishti sethi a écrit :
https://github.com/srish/learningbraille.py/blob/master/learnbraille.py
I checked your code, here are my remark :
- You should use _("A") notation only for things that must and can be
translated. This is not the case for braille letter and numbers.
- While the code is quiet clean, it is not enough generic. All the
coordinates are hardcoded, there is nothing put in common to create a
braille characters.
I expect you now to design your code so you have a braille character
object. This object should allow you to display any braille code to any
coordinate and it should be also optionally dynamic, if you click on the
point the objects should return the calculated ascii char. Do you see my
point ?
Bruno.
More information about the Gcompris-devel
mailing list