[FreeNX-kNX] freenx-client 0.9 feedback

[Seb James]

On Thu, 2008-04-10 at 12:08 +0200, Dirk Mueller wrote:
> Hi, 
> 
> some feedback from trying to build freenx-client 0.9 release:

Thanks for the feedback Dirk!

> a) it does not build with gcc 4.3. see attached patch
> 
> b) qtnx can still not install itself. see other attached patch
> 
> c) as qtnx needs pkgconfig to resolve the libnxcl, which is built in the other 
> subdir, I think it would cause less pain for the packagers of those two sub 
> directory would be separated in different tarballs. They don't share a common 
> build system anyway. 
> 
> d) the source code claims to be GPL v2+. GPL however requires to ship a GPL 
> license in a file named COPYING as part of the package. this doesn't seem to 
> be the case. Please clarify the actual license of the code. Also, list of 
> authors etc is missing as well, but I fetched them from the actual source 
> file.

An oversight. The COPYING file should be added.

> e) the autoconf/automake requires of libnxcl are extremely high, while it 
> seems to build just fine with older version of autotools, once those are 
> fixed. Is there a reason for that? this is a problem for older distributions.

These were set to whatever autotools I was working with at the time -
possible Ubuntu 6.06. I would have not objections to reducing these to
the minimum that would work.

Seb James.