[FreeNX-kNX] 64 Bit NX nxagent: Fixed and Works!

[Fabian Franz]

Hi,

here we go.

I finally managed to compile and run nxagent natively on 64bit.

And so far everything "just works". Though I haven't tested rdektop or vnc, yet ...

As always the issue was so easy in the end (especially after NoMachine had put already much effort into making it 64 bit clean).

Patch and originals of changed files are attached.

What did work from Beginning:

nxproxy * bit <-> nxproxy * bit
nxproxy 64 bit <-> nxagent 32 bit

What did not work:

nxproxy * bit <-> nxagent 64 bit

Reason was a bit field padding in nxcomp, because Drawable and GContext were pointers.

See: http://developers.sun.com/sunstudio/articles/ILP32toLP64Issues.html

Patch uses same solution as original Xorg/X11 tree, from Xproto.h:

#define pointers to CARD32 and undef later again.

Now what bounty can I claim for that most wanted feature ever ;-)?

If you want to donate: paypal at fabian-franz.de ;-).

The changes to Millis.c were necessary to get it to compile at all on 64bit.

It was also necessary to work-around the "unknown architecture" error.

I just set it to a warning. I guess the right fix is to add a #ifdef __amd64__ or something like that ...

Or look into new Xorg tree and see how its done there ...

Anyway: Enjoy this NX core components patch / release.

Copyright (even though its a trivial fix) goes to NoMachine.

cu

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nxagent-64bit-clean.diff
Type: text/x-diff
Size: 2913 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/freenx-knx/attachments/20070212/fb094175/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NXproto.h
Type: text/x-chdr
Size: 14186 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/freenx-knx/attachments/20070212/fb094175/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Millis.c
Type: text/x-csrc
Size: 1938 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/freenx-knx/attachments/20070212/fb094175/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Millis.h
Type: text/x-chdr
Size: 1398 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/freenx-knx/attachments/20070212/fb094175/attachment-0001.h>