[FreeNX-kNX] fix required for usermode to function properly

[David Mansfield]

On Fri, 2007-04-27 at 20:53 +0200, Fabian Franz wrote:
> > I just wanted to confirm that, for me, the fix to nxnode mentioned by
> > Brian Ferris in his email (thanks Brian ;-) :
> > 
> >  http://mail.kde.org/pipermail/freenx-knx/2006-December/004385.html
> > 
> > is required to get it to work for me.  In other words, the nxnode needs
> > to use 127.0.0.1 as 'userip', not the actual remote IP of the client. 
> 
> Okay, he this is really cool that there are actually people out there using the Usermode.
> 

Actually, we use it here because our users can only log in via public
key authentication.  Because it's supported at the system level, I
didn't have to move any directories, or edit any other scripts (other
than the fix to nxnode) on the server side to get this to work.  I just
had to enable the option in node.conf.  (I'm using the Centos 4 build of
nx/freenx).

On the client side, I had the users swap the nxssh for the shell script
wrapper as you had described in some earlier email.

The result is a perfectly functioning multi-user freenx installation,
without use of the 'nx' user.  Beautiful!

>              userip=$(echo $SSH_CLIENT $SSH2_CLIENT | cut -d" " -f1 | sed
> 's/::ffff://g')
> 
> -            # TODO: This logic is broken ... ;-)
> -            [ -z "$userip" ] && userip="127.0.0.1"
> -            [ -z "$userip" -a "$host" != "127.0.0.1" ] && userip="*"
> +            [ "$host" = "127.0.0.1" ] && userip="127.0.0.1"
> +            [ -z "$userip" ] && userip="*"
> 


The fix above works for me.  Thanks.

David