D27095: SearchBar - Show number of matches found on page search

[Juraj Oravec]

SGOrava added inline comments.

INLINE COMMENTS

> drosca wrote in searchtoolbar.cpp:41
> Should be hidden in the UI file.

That would make it very hard to edit in QtDesigner.
The visibility option is not even there and one needs to edit ui file manualy.
I think it is better to see it QtDesigner than not.

> drosca wrote in searchtoolbar.cpp:148
> No need, `this` will always be valid here.

I thought it can be truigerred even when this object is being killed...

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27095

To: SGOrava, #falkon, drosca
Cc: drosca, falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200202/955f612c/attachment.html>