D27095: SearchBar - Show number of matches found on page search

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> searchtoolbar.cpp:41
>  
> +    ui->resultsInfo->hide();
> +#if QTWEBENGINECORE_VERSION >= QT_VERSION_CHECK(5, 14, 0)

Should be hidden in the UI file.

> searchtoolbar.cpp:146
> +#if QTWEBENGINECORE_VERSION >= QT_VERSION_CHECK(5, 14, 0)
> +void SearchToolBar::showSearchResults(const QWebEngineFindTextResult& result)
> +{

coding style `const QWebEngineFindTextResult &result`

> searchtoolbar.cpp:148
> +{
> +    QPointer<SearchToolBar> guard = this;
> +    if (!guard) {

No need, `this` will always be valid here.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D27095

To: SGOrava, #falkon, drosca
Cc: drosca, falkon, grune, akilgus, siraj_qazi, saishm, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, clivej, mparillo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20200202/981546bd/attachment.html>