D14774: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> FindLibIntl.cmake:6
> +if (LibIntl_SYMBOL_FOUND)
> +    set(HAVE_LIBINTL 1)
> +else()

It should be TRUE/FALSE

> qmlkeyevent.h:67
> +    int modifiers() const;
> +    qint32 nativeModifiers() const;
> +    qint32 nativeScanCode() const;

Why this change?

> qmluserscript.cpp:113
> +        break;
> +    default:
> +        break;

You should probably leave the empty default case here, otherwise it will generate compile warnings.

> anmolgautam wrote in qmlplugininterface.cpp:121
> QQuickWidget takes source and not QQmlComponent - so its not suitable to use here.

https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quickwidgets/qquickwidget.h#n103

It's not documented though.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14774

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180924/712e3231/attachment.html>