D14774: Add QML Extensions API
Anmol Gautam
noreply at phabricator.kde.org
Mon Sep 24 00:30:15 BST 2018
anmolgautam added inline comments.
INLINE COMMENTS
> drosca wrote in qmlplugininterface.cpp:121
> This should return `nullptr`. Again did you test it?
>
> You should use `QQuickWidget` instead of `QWidget::createWindowContainer`.
QQuickWidget takes source and not QQmlComponent - so its not suitable to use here.
REPOSITORY
R875 Falkon
REVISION DETAIL
https://phabricator.kde.org/D14774
To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180923/689b698a/attachment.html>
More information about the Falkon
mailing list