D14214: [Feature] [Vertical Tabs] Add "Unload Tree" to Tab Tree drop-down menu

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> tabtreeview.cpp:390
> +        m->addAction(tr("Unload Tree"), this, [=]() {
> +            QVector<WebTab*> tabs;
> +            reverseTraverse(pindex, [&](const QModelIndex &index) {

You don't need to save it in vector because unloading tab doesn't change the tab tree (while closing the tab does, so that's why is it done like that there).

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14214

To: SGOrava, #falkon, drosca
Cc: drosca, falkon, tuomisto, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180718/76747be6/attachment.html>