<table><tr><td style="">drosca requested changes to this revision.<br />drosca added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14214">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14214#inline-74829">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tabtreeview.cpp:390</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">tr</span><span class="p">(</span><span style="color: #766510">"Unload Tree"</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">]()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">WebTab</span><span style="color: #aa2211">*></span> <span class="n">tabs</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">reverseTraverse</span><span class="p">(</span><span class="n">pindex</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">&</span><span class="p">](</span><span style="color: #aa4000">const</span> <span class="n">QModelIndex</span> <span style="color: #aa2211">&</span><span class="n">index</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You don't need to save it in vector because unloading tab doesn't change the tab tree (while closing the tab does, so that's why is it done like that there).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R875 Falkon</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14214">https://phabricator.kde.org/D14214</a></div></div><br /><div><strong>To: </strong>SGOrava, Falkon, drosca<br /><strong>Cc: </strong>drosca, falkon, tuomisto, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach<br /></div>