D14513: Add QML Extensions API

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> anmolgautam wrote in qmlaction.h:33
> No, the menus and action are not created by the engine, but are created (menu) in qmlplugininterface (and action in menu). But it seem to me that they leak? Should I set the parent of the qmlMenu as qmlpluginInterface or store them in a list which will be deleted in the destructor of qmlplugininterface?

You don't need to get the QmlEngine pointer in constructor, and later you call `QmlEngine::newQObject` on it, so after that you should get the correct pointer from `qmlEngine(QObject*)` I think.

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180811/0d49d8fa/attachment.html>