D14513: Add QML Extensions API

[Anmol Gautam]

anmolgautam added inline comments.

INLINE COMMENTS

> drosca wrote in qmlaction.h:33
> Why? You can get the QmlEngine pointer with `qmlEngine(QObject*)` function that is called on any QObject that was created by the engine.

No, the menus and action are not created by the engine, but are created (menu) in qmlplugininterface (and action in menu). But it seem to me that they leak? Should I set the parent of the qmlMenu as qmlpluginInterface or store them in a list which will be deleted in the destructor of qmlplugininterface?

REPOSITORY
  R875 Falkon

REVISION DETAIL
  https://phabricator.kde.org/D14513

To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180810/cf15f47b/attachment.html>