D14513: Add QML Extensions API
Anmol Gautam
noreply at phabricator.kde.org
Fri Aug 10 17:28:17 BST 2018
anmolgautam added inline comments.
INLINE COMMENTS
> drosca wrote in qmlbookmarks.cpp:233
> Why did you change the for loop? Unless there is a reason, don't use for(int i = 0, ....)
Doesn't for(BookmarkItem *bookmarkitem : items) detaches the list? Should I use QListIterator<BookmarkItem *> it(items) ?
REPOSITORY
R875 Falkon
REVISION DETAIL
https://phabricator.kde.org/D14513
To: anmolgautam, drosca
Cc: falkon, herrold, anmolgautam, SGOrava, iodelay, spoorun, ptabis, navarromorales, cochise, clivej, ach
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/falkon/attachments/20180810/70df3e86/attachment.html>
More information about the Falkon
mailing list