Headerbar navigation

Matthieu Gallien gallien.matthieu at gmail.com
Sun Jul 1 20:08:01 UTC 2018


Hello,

On dimanche 1 juillet 2018 13:22:46 CEST Alexander Stippich wrote:
> Hi Diego,
> 
> I think this would be a nice addition. Regarding the implementation, signals
> should be the way to go, e.g. create openArtist(var) and openAlbum(var)
> signals and wire that up to the ViewManager like you said. Clicking the
> title could open the "Now playing" view.

I agree. This is the approach we have tried to follow. One advantage is that 
the components are less coupled. We can more easily test them or let them 
evolve.

> Best regards,
> Alex
> 
> On Freitag, 29. Juni 2018 15:47:49 CEST Diego Gangl wrote:
> > Hey guys,
> > 
> > I had an idea for a cool feature the other day: make the artist and albums
> > in the headerbar actual buttons, so clicking on them would open the
> > corresponding view on the specific artist/album. This would be very useful
> > when you want to listen to more of an artist or an album that happened to
> > be playing.
> > 
> > I tried making a quick patch to test it but I ran into a problem. It looks
> > like I need to call a function in ViewManager to set the view, which I
> > can't access from HeaderBar (making a new instance didn't work). I thought
> > about making a signal in HeaderBar, the catch it in ElisaMainWindow and
> > call the ViewManager inside the ContentManager from there. Not sure if
> > this
> > would work or whether it would be an acceptable solution for you.
> > 
> > - What do you guys think of this feature?
> > - Do you think there is a reasonable way to do this? Without making too
> > much of a mess in the code?

Thanks for taking care of this feature. This will be a nice addition.

> > 
> > Cheers!
> > 
> > ---
> > Diego Gangl
> > sinestesia.co
> > 
> > 
> > _______________________________________________
> > Elisa mailing list
> > Elisa at kde.org
> > https://mail.kde.org/mailman/listinfo/elisa
> 
> _______________________________________________
> Elisa mailing list
> Elisa at kde.org
> https://mail.kde.org/mailman/listinfo/elisa

Best regards




More information about the Elisa mailing list