plasma-vault will require gocryptfs in Plasma 6.4

[Christophe Marin]

On samedi 26 avril 2025 11:06:21 heure d’été d’Europe centrale Nate Graham 
wrote:
> On 4/24/25 2:30 PM, Christophe Marin wrote:
> > On jeudi 24 avril 2025 14:13:39 heure d’été d’Europe centrale Nate Graham
> > 
> > wrote:
> >> On 4/24/25 2:12 PM, Christophe Marin wrote:
> >>> On jeudi 24 avril 2025 11:12:39 heure d’été d’Europe centrale Nate
> >>> Graham
> >>> 
> >>> wrote:
> >>>> Hello packagers!
> >>>> 
> >>>> This is a heads-up that in Plasma 6.4.0, plasma-vault will require
> >>>> gocryptfs. I've added it as a runtime dependency in
> >>>> https://invent.kde.org/plasma/plasma-vault/-/commit/49463366e488642c7a2
> >>>> 36
> >>>> 8f9 64605595de94cca5, so make sure that you either note this, or that
> >>>> whatever system you use for detecting runtime dependencies is working!
> >>> 
> >>> That's a bad habit we're seeing in different places: please don't mark
> >>> runtime dependencies as REQUIRED. It's always a bad idea.
> >> 
> >> Are you saying that there's something technically wrong with the commit,
> >> or commenting on the general concept of required runtime dependencies in
> >> general?
> > 
> > Both. The commit is technically wrong because it requires a runtime
> > dependency at build time. It's called 'RUNTIME' for a reason.
> 
> How so, though? As I mentioned in the other email, the find_package()
> call doesn't have REQUIRED in it, so the binary is not required on the
> build machine at build-time. REQUIRED is only set in
> set_package_properties(), making it basically just a hint to packagers.
> 

set_package_properties has the REQUIRED keyword, the result is the same. 
Instead of failing when cmake reaches the find_package() call, it will report 
that a REQUIRED dependency is missing later when it reaches feature_summary().

The set_package_properties() call also has an error, it has both type REQUIRED 
and RUNTIME, which doesn't make sense, it can only have one.

(https://cmake.org/cmake/help/latest/module/
FeatureSummary.html#command:set_package_properties)