New dependency for KPat

[Ben Cooksley]

On Mon, 28 May 2018, 05:41 Fabian K., <0inkane at googlemail.com> wrote:

> 2018-05-24 16:05 GMT+02:00 Jonathan Riddell <jr at jriddell.org>:
> >
> https://build.neon.kde.org/job/xenial_unstable_kde_kpat_bin_amd64/78/console
> > 13:31:33 -- Checking for modules 'libfreecell-solver;IMPORTED_TARGET'
> > 13:31:33 --   No package 'IMPORTED_TARGET' found
> >
> > If I remove IMPORTED_TARGET from CMakeLists.txt it compiles until the
> end when it errors with:
> > [100%] Linking CXX executable kpat
> > /usr/bin/ld: cannot find -lPkgConfig::FC_SOLVE
> >
> > changing CMakeLists.txt with
> > -    PkgConfig::FC_SOLVE
> > +    ${FC_SOLVE_LDFLAGS}
> >
> > It successfully compiles and when installed with kdegames-card-data-kf5
> it runs nicely
> >
> > Jonathan
>
> Sorry for the late reply. The IMPORTED_TARGET was added by Tobias in
> D13057 to solve a compilation issue on FreeBSD. To avoid playing a
> whack-a-mole game where fixing the compilation on one target breaks it
> on the next, could someone with a BSD system test if it still compiles
> with Jonathan's change? Thanks in advance,
>

The CI system has FreeBSD Builds which can be used to verify this once the
changes have been pushed.

Please see
https://build.kde.org/view/Applications/job/Applications%20kpat%20kf5-qt5%20FreeBSDQt5.10/

Cheers,
Ben


> Fabian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/distributions/attachments/20180528/b8a09e72/attachment.htm>