[Digikam-users] Building of the new digikam on SuSE 9.3 (rc2-tarballs)

[Gilles Caulier]

I'm not favorable to use preprocessor. It's old C style witch reduce
readability of source code.

Normaly all compile fine now with gcc 3.x. Also we will prepare the QT4 port
witch fix all these compilation problems.

Gilles


2007/3/4, Dieter Jurzitza <dieter.jurzitza at t-online.de>:
>
> Dear Gilles,
> what about something like
> // test for gcc
> #include <ansidecl.h>
>
> #if GCC_VERSION <= 3003
>        #define QSTRING Qstring::null
> #else
>        #define QSTRING Qstring()
> #fi
> and then in albumfolderview.cpp:
>
> @@ -1171,7 +1171,7 @@
>
>        QString libraryPath = parent->folderPath();
>
> -       KFileDialog dlg(QString(), "inode/directory", this,
> "importFolder", true);
> +       KFileDialog dlg(QSTRING, "inode/directory", this, "importFolder",
> true);
>        glg.setMode(KFile::Directory | KFile::Files);
>        if(dlg.exec() != QDialog::Accepted)
>            return;
>
> but I heard about real C-Programmers disliking preprocessor directives
> :-))).
>
> Nothing serious, just my 2 cents here,
> thank you for looking into this,
> take care
>
>
> Dieter Jurzitza
>
> Am Sonntag, 4. März 2007 08:40 schrieb Gilles Caulier:
> *******
> > I suspect than QString::null <==> QString() is a wrong way. The tip
> given
> *******
> --
> -----------------------------------------------------------
>
>                               |
>                                \
>                 /\_/\           |
>                | ~x~ |/-----\   /
>                 \   /-       \_/
> ^^__   _        /  _  ____   /
> <°°__ \- \_/     |  |/    |  |
> ||  ||         _| _|    _| _|
>
> if you really want to see the pictures above - use some font
> with constant spacing like courier! :-)
> -----------------------------------------------------------
> _______________________________________________
> Digikam-users mailing list
> Digikam-users at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-users/attachments/20070304/0184c9f0/attachment.html>