[Digikam-users] Fwd: Re: Exiv2 library missing???

[Fabien]

Hi,

Angelo Naselli wrote:
> Alle 13:22, giovedì 7 dicembre 2006, hai scritto:

>>>>You have to options:
>>>>1) Try to convince the kipi-devels that the current kipi configure-checks
>>>>is bad style
> 
> To convince us, they should propose something better and they should
> argue why it's bad style, or am I wrong?

I think you're right :)

>>>I'm not sure they are wrong :) Maybe KDE_PKG_CHECK_MODULES could be
>>>replaced by PKG_CHECK_MODULES in graphics/digikam/configure.in.in
>>><http://websvn.kde.org/trunk/extragear/graphics/digikam/configure.in.in?rev
>>>=609246&view=markup>
>>
>>I dont understand why digikam uses pgk-config at all when it first check for
>>exiv2-config. So digikam could simply use exiv2-config --version for the
>>version check.
> 
> Well which is the difference, since we use it for libkipi (even if it's KDE_PKG_CHECK_MODULES)
> and for libgpod? I believe a common way it's easier to maintain. Just decide which, and I believe
> once it's ok for the most, no one complains.

I think using pkg-config is the right way to do it. I did some tests 
yesterday with PKG_CHECK_MODULES instead of KDE_PKG_CHECK_MODULES, but 
it seems to lead to other issues (bad order of -L and -I which makes the 
compiler and the linker use older version of libs even if the check was 
successful). So, maybe it's more consistent to use KDE_PKG_CHECK_MODULES...
I need to investigate a bit more about that. I will give more details later.


But, in any case, it's true that there's something confusing in the 
configure script :
- first, EXIV2_CFLAGS and LIB_EXIV2 are defined :

EXIV2_CFLAGS="`$EXIV2_CONFIG --cflags`"
LIB_EXIV2="`$EXIV2_CONFIG --libs`"

- then, EXIV2_CFLAGS is redefined and a new EXIV2_LIBS is defined (and 
not LIB_EXIV2) :

EXIV2_CFLAGS=`$PKG_CONFIG --cflags "exiv2 >= 0.12"`
EXIV2_LIBS=`$PKG_CONFIG --libs "exiv2 >= 0.12"`

I don't know yet which one is the right one, but I guess we shouldn't 
have both LIB_EXIV2 and EXIV2_LIBS at the same time...


--
Fabien