New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Mon Mar 25 05:52:58 GMT 2024
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
194 new defect(s) introduced to digiKam found with Coverity Scan.
54 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 194 defect(s)
** CID 1594759: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/dplugins/webservices/o2/src/o2facebook.cpp: 89 in O2Facebook::onTokenReplyFinished()()
________________________________________________________________________________________________________
*** CID 1594759: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/dplugins/webservices/o2/src/o2facebook.cpp: 89 in O2Facebook::onTokenReplyFinished()()
83 }
84
85 // Interpret reply
86 setToken(reply.value(O2_OAUTH2_ACCESS_TOKEN, QString()).toString());
87 setExpires(reply.value(FbExpiresKey).toInt());
88 setRefreshToken(reply.value(O2_OAUTH2_REFRESH_TOKEN, QString()).toString());
>>> CID 1594759: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "reply" is passed-by-value as parameter to "setExtraTokens" when it could be moved instead.
89 setExtraTokens(reply);
90 timedReplies_.remove(tokenReply);
91 setLinked(true);
92 Q_EMIT linkingSucceeded();
93 } else {
94 qWarning() << "O2Facebook::onTokenReplyFinished:" << tokenReply->errorString();
95 }
96 }
97
** CID 1594758: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
________________________________________________________________________________________________________
*** CID 1594758: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
856
857 /* span the image with a cursor
858 * and build the new image */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
840 w1 = r->w0 + l - r->max_level + 1;
841
842 /* allocate room for new maps */
843 BUF_TRY_NEW0_RET_LQR(new_rgb, w1 * r->h0 * r->channels, r->col_depth);
844
845 if (r->root == NULL) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
844
845 if (r->root == NULL) {
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
844
845 if (r->root == NULL) {
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
840 w1 = r->w0 + l - r->max_level + 1;
841
842 /* allocate room for new maps */
843 BUF_TRY_NEW0_RET_LQR(new_rgb, w1 * r->h0 * r->channels, r->col_depth);
844
845 if (r->root == NULL) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
856
857 /* span the image with a cursor
858 * and build the new image */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
856
857 /* span the image with a cursor
858 * and build the new image */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
844
845 if (r->root == NULL) {
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
858 * and build the new image */
859 lqr_cursor_reset(r->c);
860 x = 0;
861 y = 0;
862 for (z0 = 0; z0 < w1 * r->h0; z0++, lqr_cursor_next(r->c)) {
863
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
864 LQR_CATCH_CANC(r);
865
866 /* read visibility */
867 vs = r->vs[r->c->now];
868 if ((vs != 0) && (vs <= l + r->max_level - 1)
869 && (vs >= 2 * r->max_level - 1)) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
840 w1 = r->w0 + l - r->max_level + 1;
841
842 /* allocate room for new maps */
843 BUF_TRY_NEW0_RET_LQR(new_rgb, w1 * r->h0 * r->channels, r->col_depth);
844
845 if (r->root == NULL) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 846 in lqr_carver_inflate()
840 w1 = r->w0 + l - r->max_level + 1;
841
842 /* allocate room for new maps */
843 BUF_TRY_NEW0_RET_LQR(new_rgb, w1 * r->h0 * r->channels, r->col_depth);
844
845 if (r->root == NULL) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
858 * and build the new image */
859 lqr_cursor_reset(r->c);
860 x = 0;
861 y = 0;
862 for (z0 = 0; z0 < w1 * r->h0; z0++, lqr_cursor_next(r->c)) {
863
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
864 LQR_CATCH_CANC(r);
865
866 /* read visibility */
867 vs = r->vs[r->c->now];
868 if ((vs != 0) && (vs <= l + r->max_level - 1)
869 && (vs >= 2 * r->max_level - 1)) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
858 * and build the new image */
859 lqr_cursor_reset(r->c);
860 x = 0;
861 y = 0;
862 for (z0 = 0; z0 < w1 * r->h0; z0++, lqr_cursor_next(r->c)) {
863
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
864 LQR_CATCH_CANC(r);
865
866 /* read visibility */
867 vs = r->vs[r->c->now];
868 if ((vs != 0) && (vs <= l + r->max_level - 1)
869 && (vs >= 2 * r->max_level - 1)) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 850 in lqr_carver_inflate()
844
845 if (r->root == NULL) {
846 LQR_CATCH_MEM(new_vs = g_try_new0(gint, w1 * r->h0));
847 }
848 if (r->active) {
849 if (r->bias) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 853 in lqr_carver_inflate()
847 }
848 if (r->active) {
849 if (r->bias) {
850 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, w1 * r->h0));
851 }
852 if (r->rigidity_mask) {
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
853 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, w1 * r->h0));
854 }
855 }
856
857 /* span the image with a cursor
858 * and build the new image */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
858 * and build the new image */
859 lqr_cursor_reset(r->c);
860 x = 0;
861 y = 0;
862 for (z0 = 0; z0 < w1 * r->h0; z0++, lqr_cursor_next(r->c)) {
863
>>> CID 1594758: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
864 LQR_CATCH_CANC(r);
865
866 /* read visibility */
867 vs = r->vs[r->c->now];
868 if ((vs != 0) && (vs <= l + r->max_level - 1)
869 && (vs >= 2 * r->max_level - 1)) {
** CID 1594757: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
________________________________________________________________________________________________________
*** CID 1594757: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
1472 if (r->rigidity_mask) {
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
1489 for (y = 0; y < r->h; y++) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1490 LQR_CATCH_CANC(r);
1491
1492 if (r->nrg_active) {
1493 r->raw[y] = r->_raw + y * r->w;
1494 }
1495 for (x = 0; x < r->w; x++) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
1467
1468 /* allocate room for new map */
1469 BUF_TRY_NEW0_RET_LQR(new_rgb, r->w * r->h * r->channels, r->col_depth);
1470
1471 if (r->active) {
1472 if (r->rigidity_mask) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
1489 for (y = 0; y < r->h; y++) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1490 LQR_CATCH_CANC(r);
1491
1492 if (r->nrg_active) {
1493 r->raw[y] = r->_raw + y * r->w;
1494 }
1495 for (x = 0; x < r->w; x++) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
1467
1468 /* allocate room for new map */
1469 BUF_TRY_NEW0_RET_LQR(new_rgb, r->w * r->h * r->channels, r->col_depth);
1470
1471 if (r->active) {
1472 if (r->rigidity_mask) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
1472 if (r->rigidity_mask) {
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1473 in lqr_carver_flatten()
1467
1468 /* allocate room for new map */
1469 BUF_TRY_NEW0_RET_LQR(new_rgb, r->w * r->h * r->channels, r->col_depth);
1470
1471 if (r->active) {
1472 if (r->rigidity_mask) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1483 in lqr_carver_flatten()
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1482 in lqr_carver_flatten()
1476 if (r->nrg_active) {
1477 if (r->bias) {
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1490 in lqr_carver_flatten()
1484 }
1485
1486 /* span the image with the cursor and copy
1487 * it in the new array */
1488 lqr_cursor_reset(r->c);
1489 for (y = 0; y < r->h; y++) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1490 LQR_CATCH_CANC(r);
1491
1492 if (r->nrg_active) {
1493 r->raw[y] = r->_raw + y * r->w;
1494 }
1495 for (x = 0; x < r->w; x++) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 1478 in lqr_carver_flatten()
1472 if (r->rigidity_mask) {
1473 LQR_CATCH_MEM(new_rigmask = g_try_new(gfloat, r->w * r->h));
1474 }
1475 }
1476 if (r->nrg_active) {
1477 if (r->bias) {
>>> CID 1594757: (RESOURCE_LEAK)
>>> Variable "new_rgb" going out of scope leaks the storage it points to.
1478 LQR_CATCH_MEM(new_bias = g_try_new0(gfloat, r->w * r->h));
1479 }
1480 g_free(r->_raw);
1481 g_free(r->raw);
1482 LQR_CATCH_MEM(r->_raw = g_try_new(gint, r->w * r->h));
1483 LQR_CATCH_MEM(r->raw = g_try_new(gint *, r->h));
** CID 1594756: (Y2K38_SAFETY)
/home/gilles/Devel/8.x/core/libs/rawengine/libraw/src/write/file_write.cpp: 201 in LibRaw::write_ppm_tiff()()
/home/gilles/Devel/8.x/core/libs/rawengine/libraw/src/write/file_write.cpp: 217 in LibRaw::write_ppm_tiff()()
________________________________________________________________________________________________________
*** CID 1594756: (Y2K38_SAFETY)
/home/gilles/Devel/8.x/core/libs/rawengine/libraw/src/write/file_write.cpp: 201 in LibRaw::write_ppm_tiff()()
195 {
196 if(imgdata.params.output_flags & LIBRAW_OUTPUT_FLAGS_PPMMETA)
197 fprintf(ofp,
198 "P7\n# EXPTIME=%0.5f\n# TIMESTAMP=%d\n# ISOSPEED=%d\n"
199 "# APERTURE=%0.1f\n# FOCALLEN=%0.1f\n# MAKE=%s\n# MODEL=%s\n"
200 "WIDTH %d\nHEIGHT %d\nDEPTH %d\nMAXVAL %d\nTUPLTYPE %s\nENDHDR\n",
>>> CID 1594756: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "this->imgdata.other.timestamp" is cast to "int".
201 shutter, (int)timestamp, (int)iso_speed,aperture,
202 focal_len, make, model,
203 width, height, colors, (1 << output_bps) - 1, cdesc);
204 else
205 fprintf(
206 ofp,
/home/gilles/Devel/8.x/core/libs/rawengine/libraw/src/write/file_write.cpp: 217 in LibRaw::write_ppm_tiff()()
211 {
212 if(imgdata.params.output_flags & LIBRAW_OUTPUT_FLAGS_PPMMETA)
213 fprintf(ofp, "P%d\n# EXPTIME=%0.5f\n# TIMESTAMP=%d\n"
214 "# ISOSPEED=%d\n# APERTURE=%0.1f\n# FOCALLEN=%0.1f\n"
215 "# MAKE=%s\n# MODEL=%s\n%d %d\n%d\n",
216 colors/2+5,
>>> CID 1594756: (Y2K38_SAFETY)
>>> A "time_t" value is stored in an integer with too few bits to accommodate it. The expression "this->imgdata.other.timestamp" is cast to "int".
217 shutter, (int)timestamp, (int)iso_speed,aperture,focal_len,
218 make,model,
219 width, height, (1 << output_bps)-1);
220 else
221 fprintf(ofp, "P%d\n%d %d\n%d\n", colors / 2 + 5, width, height,
222 (1 << output_bps) - 1);
** CID 1594755: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/tests/metadataengine/ratingreadwrite_utest.cpp: 130 in RatingReadWriteTest::testReadFromDisabledNamespaces()()
________________________________________________________________________________________________________
*** CID 1594755: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/tests/metadataengine/ratingreadwrite_utest.cpp: 130 in RatingReadWriteTest::testReadFromDisabledNamespaces()()
124 defaultVal << 0 << 1 << 2 << 3 << 4 << 5;
125 microsoftMappings << 0 << 1 << 25 << 50 << 75 << 99;
126 iptcMappings << 8 << 6 << 5 << 4 << 2 << 1;
127
128 NamespaceEntry ratingNs2;
129 ratingNs2.namespaceName = QLatin1String("Xmp.acdsee.rating");
>>> CID 1594755: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "defaultVal" is copied in a call to copy assignment "operator =", when it could be moved instead.
130 ratingNs2.convertRatio = defaultVal;
131 ratingNs2.nsType = NamespaceEntry::RATING;
132 ratingNs2.index = 1;
133 ratingNs2.subspace = NamespaceEntry::XMP;
134 ratingNs2.isDisabled = true;
135
** CID 1594754: Memory - corruptions (OVERRUN)
________________________________________________________________________________________________________
*** CID 1594754: Memory - corruptions (OVERRUN)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/plugins/runner/osm/OsmRelation.cpp: 145 in Marble::OsmRelation::createMultipolygon(Marble::GeoDataDocument *, QHash<long long, Marble::OsmWay> &, QHash<long long, Marble::OsmNode>&, QSet<long long> &, QSet<long long> &) const()
139 }
140
141 GeoDataPlacemark *placemark = new GeoDataPlacemark;
142 placemark->setName(m_osmData.tagValue(QStringLiteral("name")));
143 placemark->setVisualCategory(outerCategory);
144 placemark->setOsmData(osmData);
>>> CID 1594754: Memory - corruptions (OVERRUN)
>>> Overrunning callee's array of size 355 by passing argument "outerCategory" (which evaluates to 355) in call to "minimumZoomLevel".
145 placemark->setZoomLevel(StyleBuilder::minimumZoomLevel(outerCategory));
146 placemark->setPopularity(StyleBuilder::popularity(placemark));
147 placemark->setVisible(outerCategory != GeoDataPlacemark::None);
148 placemark->setGeometry(polygon);
149 if (hasMultipleOuterRings) {
150 /** @todo Use a GeoDataMultiGeometry to keep the ID? */
** CID 1594753: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 988 in lqr_carver_inflate()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 993 in lqr_carver_inflate()
________________________________________________________________________________________________________
*** CID 1594753: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 864 in lqr_carver_inflate()
858 * and build the new image */
859 lqr_cursor_reset(r->c);
860 x = 0;
861 y = 0;
862 for (z0 = 0; z0 < w1 * r->h0; z0++, lqr_cursor_next(r->c)) {
863
>>> CID 1594753: (RESOURCE_LEAK)
>>> Variable "new_rigmask" going out of scope leaks the storage it points to.
864 LQR_CATCH_CANC(r);
865
866 /* read visibility */
867 vs = r->vs[r->c->now];
868 if ((vs != 0) && (vs <= l + r->max_level - 1)
869 && (vs >= 2 * r->max_level - 1)) {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 988 in lqr_carver_inflate()
982 r->rgb = new_rgb;
983 r->preserve_in_buffer = FALSE;
984
985 if (r->root == NULL) {
986 g_free(r->vs);
987 r->vs = new_vs;
>>> CID 1594753: (RESOURCE_LEAK)
>>> Variable "new_rigmask" going out of scope leaks the storage it points to.
988 LQR_CATCH(lqr_carver_propagate_vsmap(r));
989 } else {
990 /* r->vs = NULL; */
991 }
992 if (r->nrg_active) {
993 LQR_CATCH_MEM(r->en = g_try_new0(gfloat, w1 * r->h0));
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_carver.c: 993 in lqr_carver_inflate()
987 r->vs = new_vs;
988 LQR_CATCH(lqr_carver_propagate_vsmap(r));
989 } else {
990 /* r->vs = NULL; */
991 }
992 if (r->nrg_active) {
>>> CID 1594753: (RESOURCE_LEAK)
>>> Variable "new_rigmask" going out of scope leaks the storage it points to.
993 LQR_CATCH_MEM(r->en = g_try_new0(gfloat, w1 * r->h0));
994 }
995 if (r->active) {
996 r->bias = new_bias;
997 r->rigidity_mask = new_rigmask;
998 LQR_CATCH_MEM(r->m = g_try_new0(gfloat, w1 * r->h0));
** CID 1594752: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/models/MapThemeManager.cpp: 311 in Marble::MapThemeManager::Private::findMapThemes()()
________________________________________________________________________________________________________
*** CID 1594752: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/models/MapThemeManager.cpp: 311 in Marble::MapThemeManager::Private::findMapThemes()()
305 }
306
307 QStringList MapThemeManager::Private::findMapThemes()
308 {
309 QStringList mapFilesLocal = findMapThemes( MarbleDirs::localPath() );
310 QStringList mapFilesSystem = findMapThemes( MarbleDirs::systemPath() );
>>> CID 1594752: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "mapFilesLocal" is copied in call to copy constructor "QList<QString>", when it could be moved instead.
311 QStringList allMapFiles( mapFilesLocal );
312 allMapFiles << mapFilesSystem;
313
314 // remove duplicate entries
315 allMapFiles.sort();
316 for ( int i = 1; i < allMapFiles.size(); ++i ) {
** CID 1594751: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/dplugins/webservices/o2/src/o2replyserver.cpp: 80 in O2ReplyServer::onBytesReady()()
________________________________________________________________________________________________________
*** CID 1594751: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/dplugins/webservices/o2/src/o2replyserver.cpp: 80 in O2ReplyServer::onBytesReady()()
74 qDebug() << "O2ReplyServer::onBytesReady: Malicious or service request";
75 closeServer(socket, true);
76 return; // Malicious or service (e.g. favicon.ico) request
77 }
78 qDebug() << "O2ReplyServer::onBytesReady: Query params found, closing server";
79 closeServer(socket, true);
>>> CID 1594751: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "queryParams" is passed-by-value as parameter to "verificationReceived" when it could be moved instead.
80 Q_EMIT verificationReceived(queryParams);
81 }
82
83 QMap<QString, QString> O2ReplyServer::parseQueryParams(QByteArray *data) {
84 qDebug() << "O2ReplyServer::parseQueryParams";
85
** CID 1594750: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/core/MarbleDirs.cpp: 26 in Marble::MarbleDirs::path(const QString &)()
________________________________________________________________________________________________________
*** CID 1594750: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/core/MarbleDirs.cpp: 26 in Marble::MarbleDirs::path(const QString &)()
20 QString localpath = localPath() +
21 QDir::separator() +
22 relativePath; // local path
23 QString systempath = systemPath() +
24 QDir::separator() +
25 relativePath; // system path
>>> CID 1594750: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "systempath" is copied in call to copy constructor "QString", when it could be moved instead.
26 QString fullpath = systempath;
27
28 if ( QFile::exists( localpath ) )
29 {
30 fullpath = localpath;
31 }
** CID 1594749: (COPY_INSTEAD_OF_MOVE)
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QDateTime, int>(QDebug, const QHash<T1, T2> &)()
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<int, int>(QDebug, const QHash<T1, T2> &)()
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QString, QVariant>(QDebug, const QHash<T1, T2> &)()
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QString, QList<QVariant>>(QDebug, const QHash<T1, T2> &)()
________________________________________________________________________________________________________
*** CID 1594749: (COPY_INSTEAD_OF_MOVE)
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QDateTime, int>(QDebug, const QHash<T1, T2> &)()
334 return QtPrivate::printAssociativeContainer(debug, "QMultiMap", map);
335 }
336
337 template <class Key, class T>
338 inline QDebugIfHasDebugStreamContainer<QHash<Key, T>, Key, T> operator<<(QDebug debug, const QHash<Key, T> &hash)
339 {
>>> CID 1594749: (COPY_INSTEAD_OF_MOVE)
>>> "debug" is passed-by-value as parameter to "printAssociativeContainer" when it could be moved instead.
340 return QtPrivate::printAssociativeContainer(debug, "QHash", hash);
341 }
342
343 template <class Key, class T>
344 inline QDebugIfHasDebugStreamContainer<QMultiHash<Key, T>, Key, T> operator<<(QDebug debug, const QMultiHash<Key, T> &hash)
345 {
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<int, int>(QDebug, const QHash<T1, T2> &)()
334 return QtPrivate::printAssociativeContainer(debug, "QMultiMap", map);
335 }
336
337 template <class Key, class T>
338 inline QDebugIfHasDebugStreamContainer<QHash<Key, T>, Key, T> operator<<(QDebug debug, const QHash<Key, T> &hash)
339 {
>>> CID 1594749: (COPY_INSTEAD_OF_MOVE)
>>> "debug" is passed-by-value as parameter to "printAssociativeContainer" when it could be moved instead.
340 return QtPrivate::printAssociativeContainer(debug, "QHash", hash);
341 }
342
343 template <class Key, class T>
344 inline QDebugIfHasDebugStreamContainer<QMultiHash<Key, T>, Key, T> operator<<(QDebug debug, const QMultiHash<Key, T> &hash)
345 {
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QString, QVariant>(QDebug, const QHash<T1, T2> &)()
334 return QtPrivate::printAssociativeContainer(debug, "QMultiMap", map);
335 }
336
337 template <class Key, class T>
338 inline QDebugIfHasDebugStreamContainer<QHash<Key, T>, Key, T> operator<<(QDebug debug, const QHash<Key, T> &hash)
339 {
>>> CID 1594749: (COPY_INSTEAD_OF_MOVE)
>>> "debug" is passed-by-value as parameter to "printAssociativeContainer" when it could be moved instead.
340 return QtPrivate::printAssociativeContainer(debug, "QHash", hash);
341 }
342
343 template <class Key, class T>
344 inline QDebugIfHasDebugStreamContainer<QMultiHash<Key, T>, Key, T> operator<<(QDebug debug, const QMultiHash<Key, T> &hash)
345 {
/opt/qt6/include/QtCore/qdebug.h: 340 in operator <<<QString, QList<QVariant>>(QDebug, const QHash<T1, T2> &)()
334 return QtPrivate::printAssociativeContainer(debug, "QMultiMap", map);
335 }
336
337 template <class Key, class T>
338 inline QDebugIfHasDebugStreamContainer<QHash<Key, T>, Key, T> operator<<(QDebug debug, const QHash<Key, T> &hash)
339 {
>>> CID 1594749: (COPY_INSTEAD_OF_MOVE)
>>> "debug" is passed-by-value as parameter to "printAssociativeContainer" when it could be moved instead.
340 return QtPrivate::printAssociativeContainer(debug, "QHash", hash);
341 }
342
343 template <class Key, class T>
344 inline QDebugIfHasDebugStreamContainer<QMultiHash<Key, T>, Key, T> operator<<(QDebug debug, const QMultiHash<Key, T> &hash)
345 {
** CID 1594748: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/plugins/runner/gpsbabel/GpsbabelRunner.cpp: 86 in Marble::GpsbabelRunner::parseFile(const QString &, Marble::DocumentRole, QString &)()
________________________________________________________________________________________________________
*** CID 1594748: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/plugins/runner/gpsbabel/GpsbabelRunner.cpp: 86 in Marble::GpsbabelRunner::parseFile(const QString &, Marble::DocumentRole, QString &)()
80 // Execute gpsbabel to parse the input file
81
82 int const exitStatus = QProcess::execute( command, args );
83
84 if ( exitStatus == 0 )
85 {
>>> CID 1594748: Error handling issues (CHECKED_RETURN)
>>> Calling "open" without checking return value (as is done elsewhere 157 out of 167 times).
86 kmlFile.open( QIODevice::ReadWrite );
87 GeoDataParser parser( GeoData_KML );
88 parser.read( &kmlFile );
89 GeoDataDocument *document = dynamic_cast<GeoDataDocument*>( parser.releaseDocument() );
90
91 if ( !document )
** CID 1594747: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/core/TextureColorizer.cpp: 91 in Marble::TextureColorizer::TextureColorizer(const QString &, const QString &)()
________________________________________________________________________________________________________
*** CID 1594747: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/core/TextureColorizer.cpp: 91 in Marble::TextureColorizer::TextureColorizer(const QString &, const QString &)()
85
86 for ( const QString &filename: filelist ) {
87
88 QLinearGradient gradient( 0, 0, 256, 0 );
89
90 QFile file( filename );
>>> CID 1594747: Error handling issues (CHECKED_RETURN)
>>> Calling "open" without checking return value (as is done elsewhere 157 out of 167 times).
91 file.open( QIODevice::ReadOnly );
92 QTextStream stream( &file ); // read the data from the file
93
94 QString evalstrg;
95
96 while ( !stream.atEnd() ) {
** CID 1594746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/dplugins/generic/tools/panorama/manager/panoactionthread.cpp: 311 in DigikamGenericPanoramaPlugin::PanoActionThread::compileProject(QSharedPointer<const Digikam::PTOType>, QUrl &, QUrl &, QUrl &, const QMap<QUrl, DigikamGenericPanoramaPlugin::PanoramaPreprocessedUrls> &, DigikamGenericPanoramaPlugin::PanoramaFileType, const QRect &, const QString &, const QString &, const QString &, bool, const QString &, const QString &)()
________________________________________________________________________________________________________
*** CID 1594746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/dplugins/generic/tools/panorama/manager/panoactionthread.cpp: 311 in DigikamGenericPanoramaPlugin::PanoActionThread::compileProject(QSharedPointer<const Digikam::PTOType>, QUrl &, QUrl &, QUrl &, const QMap<QUrl, DigikamGenericPanoramaPlugin::PanoramaPreprocessedUrls> &, DigikamGenericPanoramaPlugin::PanoramaFileType, const QRect &, const QString &, const QString &, const QString &, bool, const QString &, const QString &)()
305 const QString& enblendPath,
306 const QString& nonaPath)
307 {
308 QSharedPointer<Sequence> jobs(new Sequence());
309
310 QObjectDecorator* const ptoTask = new QObjectDecorator(new CreateFinalPtoTask(d->preprocessingTmpPath,
>>> CID 1594746: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "basePtoData" is passed-by-value as parameter to "DigikamGenericPanoramaPlugin::CreateFinalPtoTask::CreateFinalPtoTask(QString const &, QSharedPointer<Digikam::PTOType const>, QUrl &, QRect const &)" when it could be moved instead.
311 basePtoData,
312 panoPtoUrl,
313 crop));
314
315 connect(ptoTask, SIGNAL(started(ThreadWeaver::JobPointer)),
316 this, SLOT(slotStarting(ThreadWeaver::JobPointer)));
** CID 1594745: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/widgets/text/modelcompleter.cpp: 251 in Digikam::ModelCompleter::slotDataChanged(const QModelIndex &, const QModelIndex &)()
________________________________________________________________________________________________________
*** CID 1594745: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/widgets/text/modelcompleter.cpp: 251 in Digikam::ModelCompleter::slotDataChanged(const QModelIndex &, const QModelIndex &)()
245 qCDebug(DIGIKAM_WIDGETS_LOG) << "illegal index in changed data";
246 continue;
247 }
248
249 int id = index.data(d->uniqueIdRole).toInt();
250 QString itemName = index.data(d->displayRole).toString();
>>> CID 1594745: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "itemName" is copied in a call to copy assignment "operator =", when it could be moved instead.
251 d->idToTextHash[id] = itemName;
252
253 d->delayedModelTimer->start();
254 }
255 }
256
** CID 1594744: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/widgets/fonts/dfontproperties.cpp: 855 in Digikam::DFontProperties::Private::_d_style_chosen_slot(const QString &)()
________________________________________________________________________________________________________
*** CID 1594744: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/libs/widgets/fonts/dfontproperties.cpp: 855 in Digikam::DFontProperties::Private::_d_style_chosen_slot(const QString &)()
849 }
850
851 Q_EMIT q->fontSelected(selFont);
852
853 if (!style.isEmpty())
854 {
>>> CID 1594744: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "currentStyle" is copied in a call to copy assignment "operator =", when it could be moved instead.
855 selectedStyle = currentStyle;
856 }
857
858 signalsAllowed = true;
859 }
860
** CID 1594743: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_rwindow.c: 223 in lqr_rwindow_new_rgba()
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_rwindow.c: 207 in lqr_rwindow_new_rgba()
________________________________________________________________________________________________________
*** CID 1594743: (RESOURCE_LEAK)
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_rwindow.c: 223 in lqr_rwindow_new_rgba()
217 out_rwindow->channels = 4;
218 out_rwindow->use_rcache = use_rcache;
219 out_rwindow->carver = NULL;
220 out_rwindow->x = 0;
221 out_rwindow->y = 0;
222
>>> CID 1594743: (RESOURCE_LEAK)
>>> Variable "out_buffer_aux" going out of scope leaks the storage it points to.
223 return out_rwindow;
224 }
225
226 LqrReadingWindow *
227 lqr_rwindow_new_custom(gint radius, gboolean use_rcache, gint channels)
228 {
/home/gilles/Devel/8.x/core/libs/dimg/filters/transform/lqr/lqr_rwindow.c: 207 in lqr_rwindow_new_rgba()
201 LQR_TRY_N_N(out_rwindow = g_try_new0(LqrReadingWindow, 1));
202
203 buf_size1 = (2 * radius + 1);
204 buf_size2 = buf_size1 * buf_size1 * 4;
205
206 LQR_TRY_N_N(out_buffer_aux = g_try_new0(gdouble, buf_size2));
>>> CID 1594743: (RESOURCE_LEAK)
>>> Variable "out_buffer_aux" going out of scope leaks the storage it points to.
207 LQR_TRY_N_N(out_buffer = g_try_new0(gdouble *, buf_size1));
208 for (i = 0; i < buf_size1; i++) {
209 out_buffer[i] = out_buffer_aux + radius * 4;
210 out_buffer_aux += buf_size1 * 4;
211 }
212 out_buffer += radius;
** CID 1594742: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/osm/OsmcSymbol.cpp: 41 in OsmcSymbol::OsmcSymbol(const QString &, int)()
________________________________________________________________________________________________________
*** CID 1594742: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/8.x/core/utilities/geolocation/marble/osm/OsmcSymbol.cpp: 41 in OsmcSymbol::OsmcSymbol(const QString &, int)()
35 << QString::fromUtf8("wolfshook") << QString::fromUtf8("shell") << QString::fromUtf8("shell_modern") << QString::fromUtf8("ammonit")
36 << QString::fromUtf8("mine") << QString::fromUtf8("hiker") << QString::fromUtf8("heart") << QString::fromUtf8("tower") << QString::fromUtf8("bridleway");
37
38 if (parseTag(tag)) {
39 render();
40 }
>>> CID 1594742: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_wayWidth" is not initialized in this constructor nor in any functions that it calls.
41 }
42
43 OsmcSymbol::~OsmcSymbol()
44 {
45 delete m_foreground;
46 delete m_foreground2;
** CID 1594741: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/dplugins/bqm/metadata/translate/translate.cpp: 359 in DigikamBqmTranslatePlugin::Translate::insertTranslation(int, const QString &, Digikam::DMetadata *) const()
________________________________________________________________________________________________________
*** CID 1594741: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/home/gilles/Devel/8.x/core/dplugins/bqm/metadata/translate/translate.cpp: 359 in DigikamBqmTranslatePlugin::Translate::insertTranslation(int, const QString &, Digikam::DMetadata *) const()
353 meta->setXmpTagStringListLangAlt("Xmp.dc.rights", map);
354 break;
355 }
356
357 case Private::UsageTerms:
358 {
>>> CID 1594741: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "trOut" is copied in a call to copy assignment "operator =", when it could be moved instead.
359 map[trLang] = trOut;
360 meta->setXmpTagStringListLangAlt("Xmp.xmpRights.UsageTerms", map);
361 break;
362 }
363 }
364 }
** CID 1594740: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/libs/widgets/files/dbinarysearch.cpp: 92 in Digikam::DBinarySearch::addBinary(Digikam::DBinaryIface &)()
________________________________________________________________________________________________________
*** CID 1594740: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/8.x/core/libs/widgets/files/dbinarysearch.cpp: 92 in Digikam::DBinarySearch::addBinary(Digikam::DBinaryIface &)()
86 }
87
88 void DBinarySearch::addBinary(DBinaryIface& binary)
89 {
90 delete d->downloadLabel;
91
>>> CID 1594740: Error handling issues (CHECKED_RETURN)
>>> Calling "recheckDirectories" without checking return value (as is done elsewhere 12 out of 15 times).
92 binary.recheckDirectories();
93
94 d->binaryIfaces.append(&binary);
95 d->items.append(new QTreeWidgetItem());
96 QTreeWidgetItem* const item = d->items[d->items.size() - 1];
97 item->setIcon(Status, QIcon::fromTheme(QLatin1String("dialog-cancel")).pixmap(16, 16));
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4yJUfIaFVfulX1EnArvLvmGJ18AyhOhOJnWywYkUuR-2BHL458rbL5b5DiAzhSjilZ8-3DD3vq_wUwU8mg96yc-2FA1IAMQ6mJ-2FFdQ9EM-2BFY-2BXFbSpXNYnfyPkzN-2Fnm4gLyEjIxCqpXbrvJzKXZ-2BC4MnZVPGQ-2FZEp6oPss-2BqlNwXZG-2FelDZZULzEGobbnLhrU-2F-2Bd7VeUmdf31x-2FrxtCKLaMzCM51JX-2BOIpFirOhblnLCYDe6mBgh6eMb0o4igMfQ47A7gH59CDwgyY5IQ48G3G5IdyD52LmhyGw-3D-3D
More information about the Digikam-devel
mailing list