New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1521527:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/piwigo/piwigotalker.cpp: 239 in DigikamGenericPiwigoPlugin::PiwigoTalker::addPhoto(int, const QString &, bool, int, int, int)()


________________________________________________________________________________________________________
*** CID 1521527:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/piwigo/piwigotalker.cpp: 239 in DigikamGenericPiwigoPlugin::PiwigoTalker::addPhoto(int, const QString &, bool, int, int, int)()
233             // Image management
234     
235             QImage image = PreviewLoadThread::loadHighQualitySynchronously(mediaPath).copyQImage();
236     
237             if (image.isNull())
238             {
>>>     CID 1521527:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "load" without checking return value (as is done elsewhere 7 out of 8 times).
239                 image.load(mediaPath);
240             }
241     
242             if (image.isNull())
243             {
244                 // Invalid image

** CID 1521526:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/devel/GIT/8.x/core/utilities/geolocation/geoiface/items/gpsitemcontainer.cpp: 137 in Digikam::GPSItemContainer::GPSItemContainer(const QUrl &)()


________________________________________________________________________________________________________
*** CID 1521526:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/devel/GIT/8.x/core/utilities/geolocation/geoiface/items/gpsitemcontainer.cpp: 137 in Digikam::GPSItemContainer::GPSItemContainer(const QUrl &)()
131           m_tagList     (),
132           m_savedTagList(),
133           m_writeXmpTags(true),
134           m_saveTags    (true),
135           m_saveGPS     (true)
136     {
>>>     CID 1521526:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_writeMetaLoc" is not initialized in this constructor nor in any functions that it calls.
137     }
138     
139     GPSItemContainer::~GPSItemContainer()
140     {
141     }
142     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3D__WY_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADW-2FpF7hZHCYNryzBCooWEtWsaDmSVveEvfLL8a-2BsoaXixnM-2BdWBDl3L2-2FEoIFOKU8I8ek1wU-2Bu3jln171jO8n0-2FnQFOGC5yHueiv-2Fbq6Pb7sCwfNje0v1jKlVymTqv55lPJJ0GECUIitYI-2BJ90D-2BLJmXkHWEbI5uarwt3j4mFBoRA-3D-3D