New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

4 new defect(s) introduced to digiKam found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1520848:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/libs/widgets/mainview/dxmlguiwindow.cpp: 377 in Digikam::DXmlGuiWindow::slotSolidHardwareList()()


________________________________________________________________________________________________________
*** CID 1520848:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/libs/widgets/mainview/dxmlguiwindow.cpp: 377 in Digikam::DXmlGuiWindow::slotSolidHardwareList()()
371         showRawCameraList();
372     }
373     
374     void DXmlGuiWindow::slotSolidHardwareList()
375     {
376         SolidHardwareDlg* const dlg = new SolidHardwareDlg(qApp->activeWindow());
>>>     CID 1520848:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "exec" without checking return value (as is done elsewhere 15 out of 18 times).
377         dlg->exec();
378     }
379     
380     void DXmlGuiWindow::slotDonateMoney()
381     {
382         QUrl url(QLatin1String("https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7wQmvZSYJivCEsO7uyo0QATYQaKO3r-2Ber-2FEr242iiP8pl6a_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADV3KdS4uHlQRVh-2FVzuUBRoWEXBgHh3LLJRwTlH0yBSqAXGG0Kfu5Pz-2Ft41K-2F6qWRVR3SQWN0LsjeHRDLU5v3JuHN2LxuewOFlE1kb-2FwTYPV-2Fw-2FXevnw90-2FoBff8MicX01QLIULlCW8u2OLjJobs9vRede7oxbi6XE0D1YSpQ9B-2BBA-3D-3D

** CID 1520847:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/inaturalist/inatbrowserdlg.cpp: 148 in DigikamGenericINatPlugin::INatBrowserDlg::INatBrowserDlg(const QString &, const QList<QNetworkCookie> &, QWidget *)()


________________________________________________________________________________________________________
*** CID 1520847:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/inaturalist/inatbrowserdlg.cpp: 148 in DigikamGenericINatPlugin::INatBrowserDlg::INatBrowserDlg(const QString &, const QList<QNetworkCookie> &, QWidget *)()
142         d->browser->page()->networkAccessManager()->setCookieJar(cookieJar);
143     
144     #endif
145     
146         QDateTime now(QDateTime::currentDateTime());
147     
>>>     CID 1520847:  Performance inefficiencies  (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type QNetworkCookie.
148         for (auto cookie : cookies)
149         {
150             if (filterCookie(cookie, false, now))
151             {
152                 qCDebug(DIGIKAM_WEBSERVICES_LOG) << "Setting cookie" << cookie;
153     

** CID 1520846:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/libs/widgets/mainview/dxmlguiwindow_toolbar.cpp: 30 in Digikam::DXmlGuiWindow::slotConfToolbars()()


________________________________________________________________________________________________________
*** CID 1520846:  Error handling issues  (CHECKED_RETURN)
/home/gilles/devel/GIT/8.x/core/libs/widgets/mainview/dxmlguiwindow_toolbar.cpp: 30 in Digikam::DXmlGuiWindow::slotConfToolbars()()
24     
25         KEditToolBar dlg(factory(), this);
26     
27         connect(&dlg, SIGNAL(newToolbarConfig()),
28                 this, SLOT(slotNewToolbarConfig()));
29     
>>>     CID 1520846:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "exec" without checking return value (as is done elsewhere 15 out of 18 times).
30         dlg.exec();
31     }
32     
33     void DXmlGuiWindow::slotNewToolbarConfig()
34     {
35         KConfigGroup group = KSharedConfig::openConfig()->group(configGroupName());

** CID 1520845:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/inaturalist/inatbrowserdlg.cpp: 353 in DigikamGenericINatPlugin::INatBrowserDlg::filterCookies(const QList<QNetworkCookie> &, bool)()


________________________________________________________________________________________________________
*** CID 1520845:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/home/gilles/devel/GIT/8.x/core/dplugins/generic/webservices/inaturalist/inatbrowserdlg.cpp: 353 in DigikamGenericINatPlugin::INatBrowserDlg::filterCookies(const QList<QNetworkCookie> &, bool)()
347     QList<QNetworkCookie> INatBrowserDlg::filterCookies(const QList<QNetworkCookie>& cookies,
348                                                         bool keepSessionCookies)
349     {
350         QList<QNetworkCookie> result;
351         QDateTime now(QDateTime::currentDateTime());
352     
>>>     CID 1520845:  Performance inefficiencies  (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type QNetworkCookie.
353         for (auto cookie : cookies)
354         {
355             if (filterCookie(cookie, keepSessionCookies, now))
356             {
357                 result << cookie;
358             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DJN_D_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADV3KdS4uHlQRVh-2FVzuUBRoWUTU14xI2xpSbaZ7eWJMQuPoeBtjLIRu5PVkZgRmTM4inPuWS3Bm4B0K3jffXE8rY-2F0LPDs6-2BINp-2BbBSn88vyhYqXBxj9RY1U3gUbGntUAxOk3lCMo9cN96vUrRBSLzDX7TkQ0CvKGSWGVRia5-2BJb-2BA-3D-3D