Digikam GSoC 2021

Thu Mar 25 12:59:48 GMT 2021

Hi,

In your paper, do not forget the random generator from DImg framework
to port to pure Qt5::QRandomGenerator. This include to drop boost
dependency in this class :

https://invent.kde.org/graphics/digikam/-/blob/master/core/libs/dimg/filters/randomnumbergenerator.h

The AppImage is a very important bundle. All is build using bash scripts here :

https://invent.kde.org/graphics/digikam/-/tree/master/project/bundles/appimage

The current Qt used with AppImage in 5.14.2. We expect to upgrade to
5.15.2. The linux Mageia used to build AppImage must be also upgraded
from 6 to 7.1 (Qt 5.15 do not compile with Mageia 6).

With the APppImage the Qt ICU support is not enabled as it do not work
at run time. I try to fix it without success. Migrating to 5.15.2 can
fix the problem.

In the proposal we need a clear description of the project with all
steps/stages/plans/solutions/tests listed. This is very important to
be selected.

Best

Gilles Caulier

Le jeu. 25 mars 2021 à 13:44, Anjani Kumar <anjanik012 at gmail.com> a écrit :
>
> On Friday, March 12, 2021 3:27:49 PM IST Gilles Caulier wrote:
> > yes it sound like a suitable way for Qt6 port...
> >
> > rajce is already optional in cmake.
> >
> > Gilles Caulier
> >
> > Le ven. 12 mars 2021 à 09:55, Anjani Kumar <anjanik012 at gmail.com> a écrit :
> > > I was wondering to drop this plugin temporarily for now in the Qt6 port.
> > > If the new REST API drops XML for other formats like JSON then the new
> > > implementation can be easily written in Qt6.>
> > > On Fri, Mar 12, 2021 at 2:20 PM Anjani Kumar <anjanik012 at gmail.com> wrote:
> > >> Rajce will be releasing a new REST API sometime during 2021.
> > >> https://www.rajce.idnes.cz/api So the plugin may need a new
> > >> implementation. I don't know whether working on it temporarily until the
> > >> API changes will be worth it or not.
> > >>
> > >> On Fri, Mar 12, 2021 at 12:41 PM Gilles Caulier
> <caulier.gilles at gmail.com> wrote:
> > >>> Hi,
> > >>>
> > >>> xqilla sound like a dead project from source forge. It do not use
> > >>> cmake and for Windows it only compatible with older MSVC version.
> > >>>
> > >>> Sound like a bad idea.
> > >>>
> > >>> Yes, Rajce webservice plugin is the only code using QtXmlPatterns. If
> > >>> i remove the dependency in cmake rules, compilation crying ike that :
> > >>>
> > >>> [100%] Building CXX object
> > >>> core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugin.
> > >>> dir/rajcecommand.cpp.o Dans le fichier inclus depuis
> > >>> /home/gilles/Devel/7.x/core/dplugins/generic/webservices/rajce/rajcecomm
> > >>> and.cpp:24:
> > >>> /home/gilles/Devel/7.x/core/dplugins/generic/webservices/rajce/rajcecom
> > >>> mand.h:32:10: erreur fatale: QXmlQuery : Aucun fichier ou dossier de ce
> > >>> type
> > >>>
> > >>>    32 | #include <QXmlQuery>
> > >>>
> > >>>       |          ^~~~~~~~~~~
> > >>>
> > >>> compilation terminée.
> > >>> make[2]: ***
> > >>> [core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> n.dir/build.make:160>>>
> > >>> : core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> : n.dir/rajcecommand.cpp.o]>>>
> > >>> Erreur 1
> > >>> make[2]: *** Attente des tâches non terminées....
> > >>> Dans le fichier inclus depuis
> > >>> /home/gilles/Devel/7.x/build/core/dplugins/generic/webservices/rajce/Gen
> > >>> eric_Rajce_Plugin_autogen/EWIEGA46WW/moc_rajcecommand.cpp:10,>>>
> > >>>                  depuis
> > >>>
> > >>> /home/gilles/Devel/7.x/build/core/dplugins/generic/webservices/rajce/Gen
> > >>> eric_Rajce_Plugin_autogen/mocs_compilation.cpp:2:
> > >>> /home/gilles/Devel/7.x/build/core/dplugins/generic/webservices/rajce/Ge
> > >>> neric_Rajce_Plugin_autogen/EWIEGA46WW/../../../../../../../../core/dplug
> > >>> ins/generic/webservices/rajce/rajcecommand.h:32:10: erreur fatale:
> > >>> QXmlQuery : Aucun fichier ou dossier de ce type
> > >>>
> > >>>    32 | #include <QXmlQuery>
> > >>>
> > >>>       |          ^~~~~~~~~~~
> > >>>
> > >>> compilation terminée.
> > >>> make[2]: ***
> > >>> [core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> n.dir/build.make:82>>>
> > >>> : core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> : n.dir/Generic_Rajce_Plugin_autogen/mocs_compilation.cpp.o]>>>
> > >>> Erreur 1
> > >>> /home/gilles/Devel/7.x/core/dplugins/generic/webservices/rajce/rajcetalk
> > >>> er.cpp:34:10: erreur fatale: QXmlResultItems : Aucun fichier ou dossier
> > >>> de ce type>>>
> > >>>    34 | #include <QXmlResultItems>
> > >>>
> > >>>       |          ^~~~~~~~~~~~~~~~~
> > >>>
> > >>> compilation terminée.
> > >>> make[2]: ***
> > >>> [core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> n.dir/build.make:134>>>
> > >>> : core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugi
> > >>> : n.dir/rajcetalker.cpp.o]>>>
> > >>> Erreur 1
> > >>> make[1]: *** [CMakeFiles/Makefile2:13352 :
> > >>> core/dplugins/generic/webservices/rajce/CMakeFiles/Generic_Rajce_Plugin.
> > >>> dir/all] Erreur 2
> > >>> make: *** [Makefile:160 : all] Erreur 2
> > >>> [gilles at localhost rajce]$
> > >>>
> > >>> So only 2 classes are used from QtXmlPatterns. The question is : why
> > >>> this classes are used to talk with webservice ? Perhaps there is a
> > >>> more simplified solution to drop this dependency ?
> > >>>
> > >>> Best
> > >>>
> > >>> Gilles Caulier
> > >>>
> > >>> Le ven. 12 mars 2021 à 07:17, Anjani Kumar <anjanik012 at gmail.com> a
> écrit :
> > >>> > Hello,
> > >>> > I have looked for some possible alternatives to the QXmlPatters
> > >>> > module. I saw that the rajce plugin uses XQuery. Found this
> > >>> > http://xqilla.sourceforge.net/HomePage. Maybe we can use this. Let me
> > >>> > know what you think.
> > >>> >
> > >>> > Anjani
> > >>> >
> > >>> > On Wed, Mar 10, 2021 at 11:01 PM Anjani Kumar <anjanik012 at gmail.com>
> wrote:
> > >>> >> On Wednesday, March 10, 2021 3:11:40 PM IST Gilles Caulier wrote:
> > >>> >> > Hi,
> > >>> >> >
> > >>> >> > Welcome to the game.
> > >>> >> >
> > >>> >> > If you have questions, we are available to respond in this email
> > >>> >> >
> > >>> >> > Did you have already played with Qt6 API before?
> > >>> >> >
> > >>> >> > All point listed in idea page is enough clear for you ?
> > >>> >> >
> > >>> >> > Best regards
> > >>> >> >
> > >>> >> > Gilles Caulier
> > >>> >> >
> > >>> >> > Le mer. 10 mars 2021 à 08:14, Maik Qualmann <metzpinguin at gmail.com>
> > >>> >> > a écrit
> > >>> >> >
> > >>> >> > > Hi Anjani,
> > >>> >> > >
> > >>> >> > > Welcome, this is the right place, all active digiKam developers
> > >>> >> > > read along
> > >>> >> > > here and can answer your questions.
> > >>> >> > >
> > >>> >> > > Maik
> > >>> >> > >
> > >>> >> > > Am Mittwoch, 10. März 2021, 07:55:30 CET schrieb Anjani Kumar:
> > >>> >> > > > Hello people,
> > >>> >> > > > I have been contributing to the KDE community for an year and
> > >>> >> > > > am also
> > >>> >> > > > participating in SoK 2021(my KDE Invent[1]). I am interested in
> > >>> >> > > > porting
> > >>> >> > > > digikam to Qt6. For starters I've built digikam from source and
> > >>> >> > > > would
> > >>> >> > > > like to discuss other things. Is it the right place for
> > >>> >> > > > discussion or
> > >>> >> > > > should I email the mentors directly?
> > >>> >> > > >
> > >>> >> > > > Thanks
> > >>> >> > > > Anjani Kumar
> > >>> >> > > >
> > >>> >> > > > --------
> > >>> >> > > > [1] https://invent.kde.org/anjani
> > >>> >>
> > >>> >> Thanks for the quick responses. Tbh I haven't played "much" with Qt6.
> > >>> >> I am
> > >>> >> also assuming that this the first initiative in a KDE project to port
> > >>> >> to Qt6. All I am doing so far is look for whats changed and what
> > >>> >> others are discussing about it. I've built some examples from the
> > >>> >> Qt6 docs and that seems fine to catch up. I have worked with Qt5
> > >>> >> Network Manager and some other modules and that seems like I can
> > >>> >> port it to Qt6.
> > >>> >>
> > >>> >> The points are clear. One question I had was with Qt XML Patterns.
> > >>> >> Seems like Qt6 doesn't support this and I am not sure how to replace
> > >>> >> it's current usages in the code-base.
> > >>> >>
> > >>> >> I'll ask more once I unroll other points as well.
> > >>> >>
> > >>> >> Thanks
> > >>> >> Anjani
> I am staring to write the proposal for Qt6 port. I have some general ideas,
> hope it goes well. The first draft should be "okayish". Is there anything else
> would you like to see in a proposal? Or something I should take care of. Also
> what are your final expectations with the AppImage builder?
>
> Thanks
> Anjani
>
>