Rejection of Face Suggestions

Thanh Trung Dinh dinhthanhtrung1996 at gmail.com
Sun May 10 08:34:35 BST 2020


Hi all,

I review Kartik's code yesterday and it seems good to me. I made a comment
on gitlab but I forgot to send an email to you. Still better that Gilles
takes another look to the codes.

Best,

On Sun, May 10, 2020, 09:21 Kartik Ramesh <kartikx2000 at gmail.com> wrote:

> Apologies Gilles, I'm not sure I'm completely understanding your question.
> You can view my commits to gsoc20 branch here
> https://invent.kde.org/kde/digikam/-/commits/gsoc20-facesengine-workflow.
>
> I made changes to core/utilities/facemanagement/widgets,
> core/utilities/facemanagement/threads,
> core/utilities/facemanagement/workers, core/libs/database/tags and
> core/app/items/views.
>
> Regards
> Kartik
>
> On Sun, May 10, 2020 at 12:39 PM Gilles Caulier <caulier.gilles at gmail.com>
> wrote:
>
>> Q : Where are located exactly your commits to check in source code files ?
>> Best
>>
>> Gilles Caulier
>>
>> Le dim. 10 mai 2020 à 09:06, Gilles Caulier <caulier.gilles at gmail.com> a
>> écrit :
>> >
>> > Hi,
>> >
>> > I don't checkout your branch. I will do it now and look your code style.
>> >
>> > Best
>> >
>> > Gilles Caulier
>> >
>> > Le ven. 8 mai 2020 à 11:33, Kartik Ramesh <kartikx2000 at gmail.com> a
>> écrit :
>> > >
>> > > Hello all,
>> > >
>> > > I've been able to implement the feature for rejection of face
>> suggestions. I've made commits to the gsoc20-facesengine-workflow branch.
>> > > Please let me know if the implementation is appropriate.
>> > >
>> > > Thanks
>> > > Kartik
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20200510/4938b4a3/attachment.htm>


More information about the Digikam-devel mailing list