New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

3 new defect(s) introduced to digiKam found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1462821:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/libs/rawengine/libraw/src/decoders/crx.cpp: 157 in CrxImage::CrxImage()()


________________________________________________________________________________________________________
*** CID 1462821:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/libs/rawengine/libraw/src/decoders/crx.cpp: 157 in CrxImage::CrxImage()()
151       uint64_t mdatSize;
152       int16_t *outBufs[4]; // one per plane
153       int16_t *planeBuf;
154       LibRaw_abstract_datastream *input;
155     #ifdef LIBRAW_CR3_MEMPOOL
156       libraw_memmgr memmgr;
>>>     CID 1462821:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "input" is not initialized in this constructor nor in any functions that it calls.
157       CrxImage() : memmgr(0){}
158     #endif
159     };
160     
161     enum TileFlags
162     {

** CID 1462820:    (DEADCODE)
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_encoder_x265.cc: 640 in x265_encode_image(void *, const heif_image *, heif_image_input_class)()
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_encoder_x265.cc: 643 in x265_encode_image(void *, const heif_image *, heif_image_input_class)()


________________________________________________________________________________________________________
*** CID 1462820:    (DEADCODE)
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_encoder_x265.cc: 640 in x265_encode_image(void *, const heif_image *, heif_image_input_class)()
634     
635       // ctuSize should be a power of 2 in [16;64]
636       switch (ctuSize) {
637       case 64:
638           ctu = "64";
639           break;
>>>     CID 1462820:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 32:".
640       case 32:
641           ctu = "32";
642           break;
643       case 16:
644           ctu = "16";
645           break;
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_encoder_x265.cc: 643 in x265_encode_image(void *, const heif_image *, heif_image_input_class)()
637       case 64:
638           ctu = "64";
639           break;
640       case 32:
641           ctu = "32";
642           break;
>>>     CID 1462820:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 16:".
643       case 16:
644           ctu = "16";
645           break;
646       default:
647         struct heif_error err = {
648           heif_error_Encoder_plugin_error,

** CID 1462819:  Integer handling issues  (NO_EFFECT)
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_colorconversion.cc: 2340 in heif::ColorConversionPipeline::construct_pipeline(heif::ColorState, heif::ColorState, heif::ColorConversionOptions)()


________________________________________________________________________________________________________
*** CID 1462819:  Integer handling issues  (NO_EFFECT)
/mnt/devel/GIT/7.x/core/dplugins/dimg/heif/libheif/heif_colorconversion.cc: 2340 in heif::ColorConversionPipeline::construct_pipeline(heif::ColorState, heif::ColorState, heif::ColorConversionOptions)()
2334           if (i==0 || cost<minCost) {
2335             minIdx = i;
2336             minCost = cost;
2337           }
2338         }
2339     
>>>     CID 1462819:  Integer handling issues  (NO_EFFECT)
>>>     This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "minIdx >= 0UL".
2340         assert(minIdx>=0);
2341     
2342     
2343         // move minimum-cost border_state into processed_states
2344     
2345         processed_states.push_back(border_states[minIdx]);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPklAc1eEA-2F1zfUjH6teExFxByfkNnczn62-2Fi7fqgWZX-2BbNxhtyL5c9g-2BPgAq7MT77OPXJ5d6pc1EDZ78vhX68-3DKdin_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADVlVHw0dmDASKmSzkl9poDUo8nAqnWuNXTZY9u0c37v-2Bd-2BF9G-2F2pXW1-2BaxRAFmEvny-2B0LAL5kCwHAoSdlglKAH2NSrfV54UPqU2Pi0VXILMBs-2B029B6NPg-2Bk1WwM3iU8vc5myBg-2BMEZBDEUwj0yI3AjPX2hazb7O3KbBz1ECt40eAJi-2FwZHO3U7iuX91nJ2VwkGnLQknx1YvRnbNtdsPnsX