Facebook webservice: content access denied

[Thanh Trung Dinh]

So for clang and cppcheck I didn't see problems that really matter in my
part.

For krazy, I fixed those by changing them to QLatin1Char Is it correct?

Thanh.

On Sun, Jun 17, 2018 at 3:06 PM, Gilles Caulier <caulier.gilles at gmail.com>
wrote:

> Look the krazy report here :
>
> https://www.digikam.org/reports/krazy/gsoc18-exporttools-o2/
>
> This part is for you :
>
> Check single-char QString operations for efficiency [doublequote_chars]...*OOPS!
> 14 issues found!*
>
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += "{";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += "{";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += "}";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += "}";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += ",";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    => data += "]";
>    - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp>:
>    line# 678
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0678>
>    ,695
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0695>
>    ,701
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0701>
>    ,702
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0702>
>    ,705
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0705>
>    ,710
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0710>
>     (6)
>    - /core/utilities/assistants/webservices/smugmug/smugtalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp>:
>    => QStringList words = n.split(" ");
>    - /core/utilities/assistants/webservices/smugmug/smugtalker.cpp
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp>:
>    split issues line# 324
>    <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp#0324>
>     (1)
>
> Adding single characters to a QString is faster if the characters are
> QChars and not QStrings. For example: QString path = oldpath + "/" + base
> is better written as QString path = oldpath + '/' + base. Same holds for
> arguments to QString::startsWith(), QString::endsWith(), QString::remove(),
> QString::split(). Use QString::remove() instead of QString::replace(foo,"")
> Gilles
>
>


-- 
Mr. Thanh-Trung Dinh
Université de Technologie de Compiègne (UTC) - France
Tel: +33 7 53 68 20 29
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20180617/4c382e22/attachment.html>