<div dir="ltr"><div>So for clang and cppcheck I didn't see problems that really matter in my part. <br></div><div><br></div><div>For krazy, I fixed those by changing them to QLatin1Char Is it correct?</div><div><br></div><div>Thanh.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jun 17, 2018 at 3:06 PM, Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Look the krazy report here :<div><br></div><div><a href="https://www.digikam.org/reports/krazy/gsoc18-exporttools-o2/" target="_blank">https://www.digikam.org/<wbr>reports/krazy/gsoc18-<wbr>exporttools-o2/</a><br></div><div><br></div><div>This part is for you :</div><div><br></div><div><span class="m_-720412031414042784gmail-toolmsg" style="border-style:dotted;border-width:1px 0px;font-family:sans-serif;color:rgb(86,83,48);background:rgb(255,246,143);display:block;padding-left:8px;padding-top:4px;padding-bottom:4px;font-size:medium;text-align:left;text-decoration-style:initial;text-decoration-color:initial">Check single-char QString operations for efficiency [doublequote_chars]...<b>OOPS! 14 issues found!</b></span><ul style="margin:0px;padding:0px;list-style-type:none;color:rgb(0,0,0);font-family:"Times New Roman";font-size:medium;text-align:left;text-decoration-style:initial;text-decoration-color:initial"><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += "{";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += "{";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += "}";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += "}";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += ",";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: => data += "]";</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/google/gphoto/<wbr>gptalker.cpp</a>: line#<span> </span><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0678" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">678</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0695" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">695</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0701" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">701</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0702" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">702</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0705" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">705</a>,<a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/google/gphoto/gptalker.cpp#0710" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">710</a><span> </span><wbr>(6)</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/smugmug/<wbr>smugtalker.cpp</a>: => QStringList words = n.split(" ");</li><li style="background-image:none;background-repeat:no-repeat;margin-top:1ex;padding-left:0px"><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">/core/utilities/assistants/<wbr>webservices/smugmug/<wbr>smugtalker.cpp</a>: split issues line#<span> </span><a href="http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assistants/webservices/smugmug/smugtalker.cpp#0324" style="text-decoration:none;color:inherit;font-weight:bold" target="_blank">324</a><span> </span>(1)</li></ul><p class="m_-720412031414042784explanation" style="margin-top:1ex;margin-left:32px;padding:18px;font-size:small;border-width:1px;border-color:rgb(0,0,48);border-style:dashed;background-color:rgb(250,250,210);text-align:justify;color:rgb(0,0,0);font-family:"Times New Roman";text-decoration-style:initial;text-decoration-color:initial">Adding single characters to a QString is faster if the characters are QChars and not QStrings. For example: QString path = oldpath + "/" + base is better written as QString path = oldpath + '/' + base. Same holds for arguments to QString::startsWith(), QString::endsWith(), QString::remove(), QString::split(). Use QString::remove() instead of QString::replace(foo,"")</p><span class="HOEnZb"><font color="#888888">Gilles</font></span></div><div class="gmail_extra"><br></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><font size="2" face="comic sans ms, sans-serif">Mr. Thanh-Trung Dinh</font></div></div></div></div></div></div></div></div></div></div></div><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><font size="2" face="comic sans ms, sans-serif">Université de Technologie de Compiègne (UTC) - France<br><font color="#000000">Tel:</font><font color="#3d85c6"> </font><font color="#000000">+33 7 53 68 20 29</font></font></div></div></div></div></div></div></div></div></div></div></div>
</div></div>