patch: remove kio related legacy
caulier.gilles at gmail.com
Tue Oct 31 09:36:55 GMT 2017
I check the patch, and i think it must work. I don't yet tested the changes
and as KIO is not used anymore, this will work i think.
You need to look is no side effect are introduced by these changes,
especially with all search tools (GPS, date, tags, advanced, faces).
I recommend to not include this patch in 5.x but later in 6.0, just to be
This want mean that certainly the 6.0.0 branch must be created in git, now.
Important : there is another part not yet removed in database, and fully
relevant of KIO.
The dbus wrapping with database engine exists. The code is typically dead
and wrapped with a special pre-compiler flag : "HAVE_DBUS"
grep this string in core/libs/database area. All this code is not compiled
under Windows and MacOS, as DBUS is not available as stable components.
digiKam work as expected.
In fact under Linux, even if code is compiled, the code is never used,
because KIO slave have been removed. The goal of this code, written by
Marcel few years ago is to be able to query the DB through KIO slave and
DBus from multiple local instance of Digikam. One instance run in RW mode
with the DB, others ones in R mode only. It's a special use case of course.
Marcel can certainly explain better the concept here if necessary.
2017-10-30 18:05 GMT+01:00 Simon Frei <freisim93 at gmail.com>:
> I came across unused code like kioUrls on drag items, outdated
> mime-names for drag-drop and unused function databaseUrl() on
> imageInfos. The patch that fixes these issues is attached, it compiled
> fine. Unless there is any opposition I will push tomorrow.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Digikam-devel