New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

5 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/app/main/main.cpp: 68 in main()


________________________________________________________________________________________________________
*** CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/app/main/main.cpp: 68 in main()
62     #include "digikam_version.h"
63     #include "applicationsettings.h"
64     
65     using namespace Digikam;
66     using namespace FacesEngine;
67     
>>>     CID 1406231:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
68     int main(int argc, char* argv[])
69     {
70         QApplication app(argc, argv);
71     
72         // if we have some local breeze icon resource, prefer it
73         DXmlGuiWindow::setupIconTheme();

** CID 1406230:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/database/utils/dbinfoiface.cpp: 54 in Digikam::DBInfoIface::Private::Private()()


________________________________________________________________________________________________________
*** CID 1406230:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/database/utils/dbinfoiface.cpp: 54 in Digikam::DBInfoIface::Private::Private()()
48         Private()
49           : albumManager(AlbumManager::instance()),
50             albumChooser(0),
51             withGroupedIsSet(false),
52             withGrouped(false)
53         {
>>>     CID 1406230:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "operationType" is not initialized in this constructor nor in any functions that it calls.
54         }
55     
56         AlbumManager*                      albumManager;
57         AlbumSelectTabs*                   albumChooser;
58     
59         QList<QUrl>                        itemUrls;

** CID 1406229:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/tests/database/testdatabaseinit.cpp: 55 in main()


________________________________________________________________________________________________________
*** CID 1406229:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/tests/database/testdatabaseinit.cpp: 55 in main()
49     
50     using namespace Digikam;
51     using namespace FacesEngine;
52     
53     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
54     
>>>     CID 1406229:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
55     int main(int argc, char** argv)
56     {
57         if (argc != 2)
58         {
59             qDebug() << "testdatabaseinit - test database initialization";
60             qDebug() << "Usage: <dbtype: sqlite | mysql>";

** CID 1406228:    (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()


________________________________________________________________________________________________________
*** CID 1406228:    (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
49     
50     using namespace Digikam;
51     using namespace FacesEngine;
52     
53     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
54     
>>>     CID 1406228:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
55     int main(int argc, char** argv)
56     {
57     
58         if (argc != 2)
59         {
60             qDebug() << "testdatabaseswitch - test database switch";
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
49     
50     using namespace Digikam;
51     using namespace FacesEngine;
52     
53     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
54     
>>>     CID 1406228:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
55     int main(int argc, char** argv)
56     {
57     
58         if (argc != 2)
59         {
60             qDebug() << "testdatabaseswitch - test database switch";
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
49     
50     using namespace Digikam;
51     using namespace FacesEngine;
52     
53     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
54     
>>>     CID 1406228:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
55     int main(int argc, char** argv)
56     {
57     
58         if (argc != 2)
59         {
60             qDebug() << "testdatabaseswitch - test database switch";
/home/gilles/Devel/5.x/core/tests/database/testdatabaseswitch.cpp: 55 in main()
49     
50     using namespace Digikam;
51     using namespace FacesEngine;
52     
53     const QString IMAGE_PATH(QFINDTESTDATA("data/testimages/"));
54     
>>>     CID 1406228:    (UNCAUGHT_EXCEPT)
>>>     In function "main(int, char **)" an exception of type "std::invalid_argument" is thrown and never caught.
55     int main(int argc, char** argv)
56     {
57     
58         if (argc != 2)
59         {
60             qDebug() << "testdatabaseswitch - test database switch";

** CID 1406227:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/progressmanager/dworkingpixmap.h: 42 in ()


________________________________________________________________________________________________________
*** CID 1406227:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/progressmanager/dworkingpixmap.h: 42 in ()
36     
37     namespace Digikam
38     {
39     
40     /** A widget to draw progress wheel indicator over thumbnails.
41      */
>>>     CID 1406227:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::DWorkingPixmap" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
42     class DIGIKAM_EXPORT DWorkingPixmap
43     {
44     public:
45     
46         explicit DWorkingPixmap();
47         virtual ~DWorkingPixmap();


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTDE5SMGG-2FIxq0t5C8RJL2drmWG9SKkJXuMiexEKB1WS-2BMvP9huUaRGLQdOhT5bNuaPCS7dHA-2BtDJQPXFoOv3lIEPJ5dE3oe6w6RCC-2BQgxF8Bcayp-2BcXIOgSzkPD-2BFDaC3IZcbhk62-2B4LOknmIImmfgTXbYlUYr888RX-2Flsf-2ByObgbrfbH-2BB9dKXbLxEELfBtgU-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTDE5SMGG-2FIxq0t5C8RJL2drLaUwhnTN7aBx1iFz-2BTGWKqjDpW0U5JxCrV4zgsxQqQhMkvKNOPZ0XTmEchkqZoPItUx2jFXnkeZ9S3SLk4YHmZRp6n6tyNgrfwDSqU9QKNETxTIEuak-2FPOmLOpakKxEI5ctoU5kQVBPA74aP0J5ohjMV-2Bj1XV0YN64XGU4g7SDY-3D