New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

5 new defect(s) introduced to digiKam found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1405971:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/generator/galleryelement.cpp: 45 in Digikam::GalleryElement::GalleryElement()()


________________________________________________________________________________________________________
*** CID 1405971:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/generator/galleryelement.cpp: 45 in Digikam::GalleryElement::GalleryElement()()
39         m_time        = item.dateTime();
40     }
41     
42     GalleryElement::GalleryElement()
43         : m_valid(false)
44     {
>>>     CID 1405971:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_orientation" is not initialized in this constructor nor in any functions that it calls.
45     }
46     
47     GalleryElement::~GalleryElement()
48     {
49     }
50     

** CID 1405970:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/generator/galleryinfo.cpp: 38 in Digikam::GalleryInfo::GalleryInfo(Digikam::DInfoInterface *)()


________________________________________________________________________________________________________
*** CID 1405970:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/htmlgallery/generator/galleryinfo.cpp: 38 in Digikam::GalleryInfo::GalleryInfo(Digikam::DInfoInterface *)()
32     
33     static const char* THEME_GROUP_PREFIX = "Theme ";
34     
35     GalleryInfo::GalleryInfo(DInfoInterface* const iface)
36     {
37         m_iface = iface;
>>>     CID 1405970:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_getOption" is not initialized in this constructor nor in any functions that it calls.
38     }
39     
40     GalleryInfo::~GalleryInfo()
41     {
42     }
43     

** CID 1405969:  Uninitialized variables  (UNINIT)
/home/gilles/Devel/5.x/core/utilities/assistants/common/dinfointerface.cpp: 137 in Digikam::DItemInfo::orientation() const()


________________________________________________________________________________________________________
*** CID 1405969:  Uninitialized variables  (UNINIT)
/home/gilles/Devel/5.x/core/utilities/assistants/common/dinfointerface.cpp: 137 in Digikam::DItemInfo::orientation() const()
131     
132         if (it != m_info.end())
133         {
134             ret = it.value().toInt();
135         }
136     
>>>     CID 1405969:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "ret".
137         return ret;
138     }
139     
140     QDateTime DItemInfo::dateTime() const
141     {
142         QDateTime ret;

** CID 1405968:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/htmlgallery/htmlgallery_src_automoc.dir/moc_htmlwizard_XFF42VMCJDWCNA.cpp: 85 in Digikam::HTMLWizard::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1405968:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/htmlgallery/htmlgallery_src_automoc.dir/moc_htmlwizard_XFF42VMCJDWCNA.cpp: 85 in Digikam::HTMLWizard::qt_metacall(QMetaObject::Call, int, void **)()
79         return DWizardDlg::qt_metacast(_clname);
80     }
81     
82     int Digikam::HTMLWizard::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = DWizardDlg::qt_metacall(_c, _id, _a);
>>>     CID 1405968:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1405967:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/database/digikamdatabasemain_src_automoc.dir/moc_dbinfoiface_4KAUTMA476JNCJ.cpp: 85 in Digikam::DBInfoIface::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1405967:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/database/digikamdatabasemain_src_automoc.dir/moc_dbinfoiface_4KAUTMA476JNCJ.cpp: 85 in Digikam::DBInfoIface::qt_metacall(QMetaObject::Call, int, void **)()
79         return DInfoInterface::qt_metacast(_clname);
80     }
81     
82     int Digikam::DBInfoIface::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = DInfoInterface::qt_metacall(_c, _id, _a);
>>>     CID 1405967:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTDMTBleoEEDlQG-2Fb8PrHBaG3RSjGTEyd-2FRFkVHZq7i2kXeJ097BdcRNwvZgGxPmLptPvSLZ8-2BWnrq7gboQRCs8GZ-2FRRkc0YRoOFpHvn-2B2mDLKywCC4CCLaBi5ZSD-2Fz17qRV9Q9iLrrAJDksppbyIKjydus1qBQKP32-2F73iNraIybGyHP-2FliBL5yB5RtLdfGcBU-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTDMTBleoEEDlQG-2Fb8PrHBaGkOp8fD8-2Bn-2BnjheAZ0ilfHZefYUgXPjwyMst1UvLZKArjkdtzl5F5olZLh8WESCvQgpyXz02rDus0JfYaXKXq0kayGvtGkxNNTpSo9wMLSPIWTd5-2FrwuO96DH86LmsL-2Bh0cRRZApuTjySW1kDTPiSBqGLMFsuYIaQo8h1O4aJ4qY-3D