New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

1 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1412205:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/videoslideshow/videoslideshow_src_automoc.dir/moc_vidplayerdlg_XNM27SZU7WBRMQ.cpp: 85 in Digikam::VidPlayerDlg::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1412205:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/videoslideshow/videoslideshow_src_automoc.dir/moc_vidplayerdlg_XNM27SZU7WBRMQ.cpp: 85 in Digikam::VidPlayerDlg::qt_metacall(QMetaObject::Call, int, void **)()
79         return QDialog::qt_metacast(_clname);
80     }
81     
82     int Digikam::VidPlayerDlg::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QDialog::qt_metacall(_c, _id, _a);
>>>     CID 1412205:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTArxTeaOiZMLdoYqMRJgmI2E4Da7PNVDyooPnFeIMBZANd8eGpB4k8qd-2FuecWY4-2FeU0yR7eGp0wzvt1Si5iHLq-2BKNFjrs3UrLiQ93II04clZ-2Fn9AgieVd5kEkyr9FD4zof9-2F0amLVOlFKe0-2Fliw6w9rE53WVHJoEx9-2Fua2NztQHAhKBu77SWTYp7PRJ0NwqzP4-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTArxTeaOiZMLdoYqMRJgmI2r9xdrP6lxjz4vrOOJ3SS0BNP4qdI8g5U8X1btfFQCX2oHUGY2N7-2BE56xykAfnihq-2FYN7LxPrR-2FyYDT44lkYJoMsYVCFNhTt51N2eAwn0toPKRTkAXrA2vjErBBqk9ZPfbj4xSu6-2Fran5yJjQE2uXv3MUtZSf41-2FD-2Bm9mN9BG2Ag-3D