New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Tue Jun 6 18:28:08 BST 2017
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
6 new defect(s) introduced to digiKam found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1412042: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/eigenfacemodel.cpp: 55 in Digikam::EigenFaceMatMetadata::EigenFaceMatMetadata()()
________________________________________________________________________________________________________
*** CID 1412042: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/eigenfacemodel.cpp: 55 in Digikam::EigenFaceMatMetadata::EigenFaceMatMetadata()()
49
50 EigenFaceMatMetadata::EigenFaceMatMetadata()
51 : /*databaseId(0),*/
52 identity(0),
53 storageStatus(Created)
54 {
>>> CID 1412042: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "databaseId" is not initialized in this constructor nor in any functions that it calls.
55 }
56
57 EigenFaceMatMetadata::~EigenFaceMatMetadata()
58 {
59 }
60
** CID 1412041: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/facerec_eigenborrowed.h: 62 in Digikam::EigenFaceRecognizer::EigenFaceRecognizer(double)()
________________________________________________________________________________________________________
*** CID 1412041: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/facerec_eigenborrowed.h: 62 in Digikam::EigenFaceRecognizer::EigenFaceRecognizer(double)()
56 public:
57
58 // Initializes this Eigenfaces Model.
59 EigenFaceRecognizer(double threshold = DBL_MAX):
60 m_threshold(threshold)
61 {
>>> CID 1412041: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_num_components" is not initialized in this constructor nor in any functions that it calls.
62 }
63
64 // Initializes and computes this Eigenfaces Model.
65 EigenFaceRecognizer(cv::InputArrayOfArrays src,
66 cv::InputArray labels,
67 double threshold = DBL_MAX) :
** CID 1412040: Security best practices violations (TOCTOU)
/home/gilles/Devel/5.x/core/libs/threadimageio/dfileoperations.cpp: 136 in Digikam::DFileOperations::localFileRename(const QString &, const QString &, const QString &, bool)()
________________________________________________________________________________________________________
*** CID 1412040: Security best practices violations (TOCTOU)
/home/gilles/Devel/5.x/core/libs/threadimageio/dfileoperations.cpp: 136 in Digikam::DFileOperations::localFileRename(const QString &, const QString &, const QString &, bool)()
130 return false;
131 }
132
133 #ifndef Q_OS_WIN
134
135 // restore permissions
>>> CID 1412040: Security best practices violations (TOCTOU)
>>> Calling function "chmod" that uses "dstFileName.constData()" after a check function. This can cause a time-of-check, time-of-use race condition.
136 if (::chmod(dstFileName.constData(), filePermissions) != 0)
137 {
138 qCWarning(DIGIKAM_GENERAL_LOG) << "Failed to restore file permissions for file "
139 << dstFileName;
140 }
141
** CID 1412039: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/AudioFrame.h: 31 in ()
________________________________________________________________________________________________________
*** CID 1412039: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/AudioFrame.h: 31 in ()
25 #include <QtAV/Frame.h>
26 #include <QtAV/AudioFormat.h>
27
28 namespace QtAV {
29 class AudioResampler;
30 class AudioFramePrivate;
>>> CID 1412039: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "QtAV::AudioFrame" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
31 class Q_AV_EXPORT AudioFrame : public Frame
32 {
33 Q_DECLARE_PRIVATE(AudioFrame)
34 public:
35 //data must be complete
36 /*!
** CID 1412038: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/Packet.h: 33 in ()
________________________________________________________________________________________________________
*** CID 1412038: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/Packet.h: 33 in ()
27
28 struct AVPacket;
29
30 namespace QtAV {
31
32 class PacketPrivate;
>>> CID 1412038: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "QtAV::Packet" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33 class Q_AV_EXPORT Packet
34 {
35 public:
36 static Packet fromAVPacket(const AVPacket* avpkt, double time_base);
37 static bool fromAVPacket(Packet *pkt, const AVPacket *avpkt, double time_base);
38 static Packet createEOF();
** CID 1412037: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/eigenfacemodel.h: 82 in ()
________________________________________________________________________________________________________
*** CID 1412037: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/facesengine/recognition-opencv-eigenfaces/eigenfacemodel.h: 82 in ()
76
77 StorageStatus storageStatus;
78 };
79
80 // -------------------------------------------------------------------------------------------------------------------------------------
81
>>> CID 1412037: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "Digikam::EigenFaceModel" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
82 class EigenFaceModel : public cv::Ptr<EigenFaceRecognizer>
83 {
84 public:
85
86 EigenFaceModel();
87 ~EigenFaceModel();
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTD5oE-2ByG6SCDe8ui503IBw2N47VlHEpUO7IRFUiFUrlG-2FSf9grWpaolb7rawaSZdLEyybCo2DSe8w9cWjEW2agX2BQS-2FUchmHA2XqAaHfrva3g7HHPLjdHxfU-2F2aGQNTo275ObGz5WwHLZxvDmnx-2FQ4WVPP63aPO4-2B-2F7mMBGeBeIKUf3DXGEb1pxtwRRLaaSUE-3D
To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTD5oE-2ByG6SCDe8ui503IBw2REu-2BdLmmwdxepH-2FXGg7KFGtSVU0aSgSPHsMSBClvzNswArEOLnwHqyZuPoNtfPh3JOag-2F1U8gKtNU7jqJ5VOHdrhPkBknPm7BCK0CYrOvlg3JOfeBBWDGPMS1eSXcCwovo2blj-2FwsWiabaJk40Ze4KGJTMFa4jJkEUik2jS79RQ-3D
More information about the Digikam-devel
mailing list