patch for 296580

[Gilles Caulier]

yes, the bug must be closed automatically. this is the goal of git hook
scripts.

Gilles

2017-01-03 12:44 GMT+01:00 Markus Leuthold <digikam at titlis.org>:

> Hi Gilles
>
> Happy new year for you too! I committed (along with some whitespace fixes
> and comments).
>
> After git push, the server responds
>
> remote: https://commits.kde.org/digikam/72c97cef18b260d2143261b72373e7
> ba53ba3dfb
> remote: Closing bug 296580
>
> Does that mean the bko entry is closed automatically by a post commit
> hook? or do I need to do it manually? Right now, the bug is still open on
> Bugzilla
>
> best, Markus
>
> On 3 January 2017 at 09:36, Gilles Caulier <caulier.gilles at gmail.com>
> wrote:
>
>> The patch is fine for me. You can commit.
>>
>> Don't forget to include the bugzilla title at end of digikam core NEWS
>> file for next release announcement. Close bugzilla entry with FIXED-IN set
>> to 5.4.0
>>
>> Best
>>
>> Gilles
>>
>>
>>
>>
>>
>> 2017-01-03 9:28 GMT+01:00 Gilles Caulier <caulier.gilles at gmail.com>:
>>
>>> Hi Markus and happy new year 2017
>>>
>>> reviewboard give duplicates feature than bugzilla. This last one is more
>>> powerfull and is the core of Agile project management.
>>>
>>> I'm not favorable to use it. Bugzilla is enough, and optimum.
>>>
>>> I will look in your patch today. Thanks for your contribution.
>>>
>>> Best
>>>
>>> Gilles Caulier
>>>
>>> 2017-01-03 2:19 GMT+01:00 Markus Leuthold <digikam at titlis.org>:
>>>
>>>> Hi all
>>>>
>>>> could you please review https://git.reviewboard.kde.org/r/129755/ ?
>>>> May I commit this?
>>>>
>>>> thanks!
>>>> Kusi
>>>>
>>>> PS: How does the review process work nowadays? Is the reviewboard fine
>>>> or do you have some pull request mechanism?
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20170103/bb2b9a18/attachment.html>