[digikam] [Bug 372217] The results of the Duplicates are currently sorted by the image id and sortable by name and count if similars. But it should be sortable by the similarity of the duplicates, too. [patch]

bugzilla_noreply at kde.org bugzilla_noreply at kde.org
Thu Nov 10 05:37:29 GMT 2016


caulier.gilles at gmail.com changed:

           What    |Removed                     |Added
   Version Fixed In|                            |5.4.0
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/04c4024d4c7d3f03d91ed89
                   |                            |2286c2de78abeeb37
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from caulier.gilles at gmail.com ---
Git commit 04c4024d4c7d3f03d91ed892286c2de78abeeb37 by Gilles Caulier.
Committed on 10/11/2016 at 05:33.
Pushed by cgilles into branch 'master'.

Apply patches #102120 and #102121 from Mario Frank

102120: Extended the duplicates search list view. Now, the average
similarity of the found duplicates (excluding the original image) is shown as
table column. Sorting the result set by the average similarity is thus
possible. To implement this feature, the haariface had to be modified. It
returns a map of average similarities to a map of image ids to the set of
similar images instead of the map of image ids to the set of similar images.
Communicating the average similarity to the search list view was not possible
via slots and signals and this would have lead to sending a map of image ids
to average similarities and then distributing the appropriate average
similarity to the correct FindDuplicateAlbumItem. Instead, the average
similarity is communicated via the SearchXml-query as a field of the group.
This way, the correct item gets the correct similarity automatically. The
evaluation of the new field by an SQL query is surpressed by the introduction
of noEffect fields which need to have a prefix "noeffect_". So, the log is
not polluted by unnecessary debug information.

102121: The items in the FindDuplicatesAlbum were sorted by
lexicographic order which does not make sense for the average similarity
column (e.g. 100.00 is not correctly sorted). Thus, the less than operator
was adopted such that for the average similarity column, arithmetic order is
used. To make the code more stable against regressions due to reordering the
columns, an enum was introduced.
FIXED-IN: 5.4.0
CCMAIL: frank at uni-potsdam.de

M  +60   -30   libs/database/haar/haariface.cpp
M  +5    -5    libs/database/haar/haariface.h
M  +1    -1    libs/database/item/imagelister.cpp
M  +5    -1    libs/database/item/imagequerybuilder.cpp
M  +3    -2    utilities/fuzzysearch/findduplicatesalbum.cpp
M  +27   -4    utilities/fuzzysearch/findduplicatesalbumitem.cpp
M  +9    -0    utilities/fuzzysearch/findduplicatesalbumitem.h
M  +4    -4    utilities/fuzzysearch/findduplicatesview.cpp
M  +9    -6    utilities/fuzzysearch/fuzzysearchview.cpp


You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list