[Digikam-devel] New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Wed Oct 21 19:08:50 BST 2015
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
9 new defect(s) introduced to digiKam found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 9 of 9 defect(s)
** CID 1328481: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/sendimages/imageresize.cpp: 68 in KIPISendimagesPlugin::Task::Task(int *)()
________________________________________________________________________________________________________
*** CID 1328481: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/sendimages/imageresize.cpp: 68 in KIPISendimagesPlugin::Task::Task(int *)()
62 PluginLoader* const pl = PluginLoader::instance();
63
64 if (pl)
65 {
66 m_iface = pl->interface();
67 }
>>> CID 1328481: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_iface" is not initialized in this constructor nor in any functions that it calls.
68 }
69
70 Task::~Task()
71 {
72 }
73
** CID 1328480: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/advancedslideshow/widgets/playbackwidget.cpp: 84 in KIPIAdvancedSlideshowPlugin::PlaybackWidget::PlaybackWidget(QWidget *, QList<QUrl> &, KIPIAdvancedSlideshowPlugin::SharedContainer *)()
________________________________________________________________________________________________________
*** CID 1328480: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/advancedslideshow/widgets/playbackwidget.cpp: 84 in KIPIAdvancedSlideshowPlugin::PlaybackWidget::PlaybackWidget(QWidget *, QList<QUrl> &, KIPIAdvancedSlideshowPlugin::SharedContainer *)()
78 connect(m_stopButton, SIGNAL(clicked()),
79 this, SLOT(slotStop()));
80
81 if (m_urlList.empty())
82 {
83 setEnabled(false);
>>> CID 1328480: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_volumeSlider" is not initialized in this constructor nor in any functions that it calls.
84 return;
85 }
86
87 // Waiting for files to be enqueued.
88 m_playButton->setEnabled(false);
89
** CID 1328479: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/imgur/imgurwidget.cpp: 71 in KIPIImgurPlugin::ImgurWidget::Private::Private()()
________________________________________________________________________________________________________
*** CID 1328479: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/imgur/imgurwidget.cpp: 71 in KIPIImgurPlugin::ImgurWidget::Private::Private()()
65 iface = pl->interface();
66 }
67
68 #ifdef OAUTH_ENABLED
69 changeUserBtn = 0;
70 #endif //OAUTH_ENABLED
>>> CID 1328479: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "iface" is not initialized in this constructor nor in any functions that it calls.
71 }
72
73 QLabel* headerLbl;
74 ImgurImagesList* imagesList;
75 KPProgressWidget* progressBar;
76 int processedCount;
** CID 1328478: (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 272 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 279 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
________________________________________________________________________________________________________
*** CID 1328478: (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 272 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
266 addKmlTextElement(kmlPlacemark, QLatin1String("name"), fullFileName);
267 // location and altitude
268 QDomElement kmlGeometry = addKmlElement(kmlPlacemark, QLatin1String("Point"));
269
270 if (alt)
271 {
>>> CID 1328478: (UNINIT)
>>> Using uninitialized value "lng" when calling "arg".
272 addKmlTextElement(kmlGeometry, QLatin1String("coordinates"), QString::fromUtf8("%1,%2,%3 ")
273 .arg(lng, 0, 'f', 8)
274 .arg(lat, 0, 'f', 8)
275 .arg(alt, 0, 'f', 8));
276 }
277 else
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 279 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
273 .arg(lng, 0, 'f', 8)
274 .arg(lat, 0, 'f', 8)
275 .arg(alt, 0, 'f', 8));
276 }
277 else
278 {
>>> CID 1328478: (UNINIT)
>>> Using uninitialized value "lng" when calling "arg".
279 addKmlTextElement(kmlGeometry, QLatin1String("coordinates"), QString::fromUtf8("%1,%2 ")
280 .arg(lng, 0, 'f', 8)
281 .arg(lat, 0, 'f', 8));
282 }
283
284 if (m_altitudeMode == 2 )
** CID 1328477: (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 272 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 279 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
________________________________________________________________________________________________________
*** CID 1328477: (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 272 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
266 addKmlTextElement(kmlPlacemark, QLatin1String("name"), fullFileName);
267 // location and altitude
268 QDomElement kmlGeometry = addKmlElement(kmlPlacemark, QLatin1String("Point"));
269
270 if (alt)
271 {
>>> CID 1328477: (UNINIT)
>>> Using uninitialized value "lat" when calling "arg".
272 addKmlTextElement(kmlGeometry, QLatin1String("coordinates"), QString::fromUtf8("%1,%2,%3 ")
273 .arg(lng, 0, 'f', 8)
274 .arg(lat, 0, 'f', 8)
275 .arg(alt, 0, 'f', 8));
276 }
277 else
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 279 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
273 .arg(lng, 0, 'f', 8)
274 .arg(lat, 0, 'f', 8)
275 .arg(alt, 0, 'f', 8));
276 }
277 else
278 {
>>> CID 1328477: (UNINIT)
>>> Using uninitialized value "lat" when calling "arg".
279 addKmlTextElement(kmlGeometry, QLatin1String("coordinates"), QString::fromUtf8("%1,%2 ")
280 .arg(lng, 0, 'f', 8)
281 .arg(lat, 0, 'f', 8));
282 }
283
284 if (m_altitudeMode == 2 )
** CID 1328476: Uninitialized variables (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 270 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
________________________________________________________________________________________________________
*** CID 1328476: Uninitialized variables (UNINIT)
/home/gilles/Devel/5.x/extra/kipi-plugins/kmlexport/kmlexport.cpp: 270 in KIPIKMLExportPlugin::KmlExport::generateImagesthumb(const QUrl &, QDomElement &)()
264
265 QDomElement kmlPlacemark = addKmlElement(kmlAlbum, QLatin1String("Placemark"));
266 addKmlTextElement(kmlPlacemark, QLatin1String("name"), fullFileName);
267 // location and altitude
268 QDomElement kmlGeometry = addKmlElement(kmlPlacemark, QLatin1String("Point"));
269
>>> CID 1328476: Uninitialized variables (UNINIT)
>>> Using uninitialized value "alt".
270 if (alt)
271 {
272 addKmlTextElement(kmlGeometry, QLatin1String("coordinates"), QString::fromUtf8("%1,%2,%3 ")
273 .arg(lng, 0, 'f', 8)
274 .arg(lat, 0, 'f', 8)
275 .arg(alt, 0, 'f', 8));
** CID 1328475: Incorrect expression (MIXED_ENUMS)
/home/gilles/Devel/5.x/core/libs/jpegutils/jpegutils.cpp: 582 in Digikam::JPEGUtils::JpegRotator::performJpegTransform(Digikam::MetaEngineRotation::TransformationAction, const QString &, const QString &)()
________________________________________________________________________________________________________
*** CID 1328475: Incorrect expression (MIXED_ENUMS)
/home/gilles/Devel/5.x/core/libs/jpegutils/jpegutils.cpp: 582 in Digikam::JPEGUtils::JpegRotator::performJpegTransform(Digikam::MetaEngineRotation::TransformationAction, const QString &, const QString &)()
576 transformoption.perfect = true; // See bug 320107 : we need perfect transform here.
577 transformoption.crop = false;
578
579 #endif // (JPEG_LIB_VERSION >= 80)
580
581 // NOTE : Cast is fine here. See metaengine_rotation.h for details.
>>> CID 1328475: Incorrect expression (MIXED_ENUMS)
>>> Mixing enum types "JXFORM_CODE" and "Digikam::MetaEngineRotation::TransformationAction" for "transform".
582 transformoption.transform = (JXFORM_CODE)action;
583
584 if (transformoption.transform == JXFORM_NONE)
585 {
586 return true;
587 }
** CID 1328474: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/5.x/core/libs/dmetadata/metaengine_gps.cpp: 53 in Digikam::MetaEngine::getGPSInfo(double &, double &, double &) const()
________________________________________________________________________________________________________
*** CID 1328474: Error handling issues (CHECKED_RETURN)
/home/gilles/Devel/5.x/core/libs/dmetadata/metaengine_gps.cpp: 53 in Digikam::MetaEngine::getGPSInfo(double &, double &, double &) const()
47 {
48
49 bool MetaEngine::getGPSInfo(double& altitude, double& latitude, double& longitude) const
50 {
51 // Some GPS device do not set Altitude. So a valid GPS position can be with a zero value.
52 // No need to check return value.
>>> CID 1328474: Error handling issues (CHECKED_RETURN)
>>> Calling "getGPSAltitude" without checking return value (as is done elsewhere 5 out of 6 times).
53 getGPSAltitude(&altitude);
54
55 if (!getGPSLatitudeNumber(&latitude))
56 return false;
57
58 if (!getGPSLongitudeNumber(&longitude))
** CID 1308780: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/googleservices/gdtalker.cpp: 89 in KIPIGoogleServicesPlugin::GDTalker::GDTalker(QWidget *)()
________________________________________________________________________________________________________
*** CID 1308780: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/googleservices/gdtalker.cpp: 89 in KIPIGoogleServicesPlugin::GDTalker::GDTalker(QWidget *)()
83 PluginLoader* const pl = PluginLoader::instance();
84
85 if (pl)
86 {
87 m_iface = pl->interface();
88 }
>>> CID 1308780: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_iface" is not initialized in this constructor nor in any functions that it calls.
89 }
90
91 GDTalker::~GDTalker()
92 {
93 }
94
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview
To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8
More information about the Digikam-devel
mailing list