[Digikam-devel] New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1338423:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/facesengine/moc_databasefacebackend.cpp: 85 in FacesEngine::DatabaseFaceBackend::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1338423:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/facesengine/moc_databasefacebackend.cpp: 85 in FacesEngine::DatabaseFaceBackend::qt_metacall(QMetaObject::Call, int, void **)()
79         return DatabaseCoreBackend::qt_metacast(_clname);
80     }
81     
82     int FacesEngine::DatabaseFaceBackend::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = DatabaseCoreBackend::qt_metacall(_c, _id, _a);
>>>     CID 1338423:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1338422:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/database/moc_thumbnaildatabasebackend.cpp: 85 in Digikam::ThumbnailDatabaseBackend::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1338422:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/libs/database/moc_thumbnaildatabasebackend.cpp: 85 in Digikam::ThumbnailDatabaseBackend::qt_metacall(QMetaObject::Call, int, void **)()
79         return DatabaseCoreBackend::qt_metacast(_clname);
80     }
81     
82     int Digikam::ThumbnailDatabaseBackend::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = DatabaseCoreBackend::qt_metacall(_c, _id, _a);
>>>     CID 1338422:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8