[Digikam-devel] [digikam] [Bug 345144] New: remove kdelibs4support not finished (frameworks branch)

[Gustavo Alvarez]

https://bugs.kde.org/show_bug.cgi?id=345144

            Bug ID: 345144
           Summary: remove kdelibs4support not finished (frameworks
                    branch)
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: grave
          Priority: NOR
         Component: general
          Assignee: digikam-devel at kde.org
          Reporter: sl1pkn07 at gmail.com

when build a latest git code from digikam (frameworks branch) projects.kde.org,
fail build (in "configure" step) with this message:

CMake Error at CMakeLists.txt:313 (MACRO_BOOL_TO_01):
  Unknown CMake command "MACRO_BOOL_TO_01".


-- Configuring incomplete, errors occurred!
See also
"/home/sl1pkn07/aplicaciones/digikam-frameworks-git/src/build/CMakeFiles/CMakeOutput.log".


MACRO_BOOL_TO_01 is provided by kdelibs4ssupport

to fix this message is need, if don't want add kdelibs4support to dependecies
again, copy the 'MacroBoolTo01.cmake' from kdelibs4support to
'digikam/cmake/modules folde'r, and add this in main digikam CMakeLists.txt:

include(MacroBoolTo01)


but with this still fails. because in:

http://quickgit.kde.org/?p=digikam.git&a=blob&h=37d4e73ea0f2b1200c9d46fa4bffb103f244cca0&hb=896a82c1f487e14c0c4bb8e1ef4bafd23a033b00&f=showfoto%2FCMakeLists.txt#l41

and

http://quickgit.kde.org/?p=digikam.git&a=blob&h=d63afc0573a7d35e08dd2409209860b126d5e630&hb=896a82c1f487e14c0c4bb8e1ef4bafd23a033b00&f=app%2FCMakeLists.txt#l210

points to need more kdelibs4support macros

to solve this, i handle those like a this method on kruler commit:

http://quickgit.kde.org/?p=kruler.git&a=blob&h=a1be586bd589501fd9043b9bd06304593fa5a8d6&hb=b49f9869a5e8977006a37864f1d577c25f0e11af&f=CMakeLists.txt#l53

I had attach a patch to add those changes:

http://sl1pkn07.wtf/paste/view/raw/ffc60aa1

please review it

greetings


Reproducible: Always

Steps to Reproduce:
1. install "stable" kf5 frameworks
2. download digikam frameworks branch code
3. try to build

Actual Results:  
fail build

Expected Results:  
build OK

-- 
You are receiving this mail because:
You are the assignee for the bug.