[Digikam-devel] Review Request 109453: Patch to enable digikam to write face tags into xmp metadata Ver2 + tag update when Images are rotated [Experimental]

[Veaceslav Munteanu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109453/
-----------------------------------------------------------

(Updated April 7, 2015, 12:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for Digikam, Gilles Caulier and Marcel Wiesweg.


Repository: digikam


Description
-------

This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/

Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.

I'm still working on it, any feedback about implementation is welcome.

It's not the last version, still have few issues to fix(see testing below).


Diffs
-----

  digikam/fileaction/fileactionmngr.h 836bc17 
  digikam/fileaction/fileactionmngr.cpp 83372c2 
  digikam/fileaction/fileactionmngr_p.h d0e418b 
  digikam/fileaction/fileactionmngr_p.cpp c09ce30 
  digikam/fileaction/fileworkeriface.h a04b71e 
  digikam/fileaction/fileworkeriface.cpp 76842eb 
  digikam/fileaction/metadatahub.cpp ea74590 
  digikam/views/imagepreviewview.h 95102ed 
  digikam/views/imagepreviewview.cpp 65b92dd 
  libs/database/core/tagregion.h 436960f 
  libs/database/core/tagregion.cpp 4fda6af 
  libs/dmetadata/metadatasettingscontainer.h 02d35d2 
  libs/dmetadata/metadatasettingscontainer.cpp 3e6cd93 
  utilities/facemanagement/facegroup.h 2f0a357 
  utilities/facemanagement/facegroup.cpp df9dec4 
  utilities/setup/setupmetadata.cpp f73870c 

Diff: https://git.reviewboard.kde.org/r/109453/diff/


Testing
-------

So far, metadata write works ok.

And rotation from image preview updates all tags from database and also updates face rectangles.

What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.

What can be tested:

1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.


Thanks,

Veaceslav Munteanu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20150407/3a48aa0d/attachment.html>