<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109453/">https://git.reviewboard.kde.org/r/109453/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Digikam, Gilles Caulier and Marcel Wiesweg.</div>
<div>By Veaceslav Munteanu.</div>
<p style="color: grey;"><i>Updated April 7, 2015, 12:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the stage 2 of enabling digikam to read/write Picassa metadata into images.
It also include this previous patch: https://git.reviewboard.kde.org/r/109087/
Now, workeriface will rotate all face tags when image is rotated and image preview will update tags position when rotation is triggered.
I'm still working on it, any feedback about implementation is welcome.
It's not the last version, still have few issues to fix(see testing below).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So far, metadata write works ok.
And rotation from image preview updates all tags from database and also updates face rectangles.
What should be done(I work on it): Trigger metadata write when rotated. If tags are not updated(but this can be done manually), every rotation trigger metadata reread and garbage tags appear.
What can be tested:
1. Write metadata to files
2. Assign tags and rotate image, see if tag rectangles are in position.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>digikam/fileaction/fileactionmngr.h <span style="color: grey">(836bc17)</span></li>
<li>digikam/fileaction/fileactionmngr.cpp <span style="color: grey">(83372c2)</span></li>
<li>digikam/fileaction/fileactionmngr_p.h <span style="color: grey">(d0e418b)</span></li>
<li>digikam/fileaction/fileactionmngr_p.cpp <span style="color: grey">(c09ce30)</span></li>
<li>digikam/fileaction/fileworkeriface.h <span style="color: grey">(a04b71e)</span></li>
<li>digikam/fileaction/fileworkeriface.cpp <span style="color: grey">(76842eb)</span></li>
<li>digikam/fileaction/metadatahub.cpp <span style="color: grey">(ea74590)</span></li>
<li>digikam/views/imagepreviewview.h <span style="color: grey">(95102ed)</span></li>
<li>digikam/views/imagepreviewview.cpp <span style="color: grey">(65b92dd)</span></li>
<li>libs/database/core/tagregion.h <span style="color: grey">(436960f)</span></li>
<li>libs/database/core/tagregion.cpp <span style="color: grey">(4fda6af)</span></li>
<li>libs/dmetadata/metadatasettingscontainer.h <span style="color: grey">(02d35d2)</span></li>
<li>libs/dmetadata/metadatasettingscontainer.cpp <span style="color: grey">(3e6cd93)</span></li>
<li>utilities/facemanagement/facegroup.h <span style="color: grey">(2f0a357)</span></li>
<li>utilities/facemanagement/facegroup.cpp <span style="color: grey">(df9dec4)</span></li>
<li>utilities/setup/setupmetadata.cpp <span style="color: grey">(f73870c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109453/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>