[Digikam-devel] Questionable commit to digikam's frameworks branch?

[Veaceslav Munteanu]

Teemu,

the reason I was concerned is because, baloo lib is compiled as static
and KI18n is also included in whole executable. I don't see any
reasons link to baloo when it is static. (Or I don't get how Cmake
works)

That means it might be a include problem.

Also, somebody changed baloo to STATIC again. Did you also check if it
works as static? Because I changed it to SHARED because of it not
reading the correct settings.

Veaceslav

On Sun, Apr 5, 2015 at 2:31 AM, Teemu Rytilahti <tpr at iki.fi> wrote:
> Marko Käning wrote:
>
> Hi Marko, and thanks for your commit. I have been on holidays and thus
> haven't been following mailinglists lately.
>
>> Teemu, could you check whether my below commit to Baloo’s CMakeLists.txt
>> is okay or not?
>
>>> It is not the best idea because I think there is a include problem
>>> rather than linking, and what I did right now was to link in other
>>> place, except digiKam's executable..
>
> The fix depends on the error of course, but if there is something using the
> k18n headers, the library probably should also be linked, no? If the used
> header is from some other library which becomes added to the include path by
> including the k18n then this solution is wrong :-)
>
> --
> Best Regards,
> Teemu Rytilahti
>
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel