[Digikam-devel] [digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files

[Vincent Tassy]

https://bugs.kde.org/show_bug.cgi?id=205776

--- Comment #63 from Vincent Tassy <timetre at free.fr> ---
Ok, I did a little gdb session and here's what I I saw:

First of all, my screen  resolution is 2560x1440
RAW file being displayed is 4000x3000
JPG preview embedded in the RAW file is 1600x1200

in dimgpreviewitem.cpp, the previewSize is set to 2560

Then, when stepping through previewtask.cpp

line 213: size = 2560 (which is the previewSize set before and = width of my
screen)
line 241: bestSize = 4000 (this is the width of my RAW image)
line 247: bestSize = 2000 (4000 / 2)
line 259: aBitSmallerThanSize = 2048 (2560 * 0.8)
line 260: sizeLimit = 2000
line 293: KDCRaw loads the preview : width = 1600 and height = 1200 (correct)

The test takes us to line 305 (loadHalfPreview) since 1600 < 2000

So the behaviour is correct, all the sizes (screen , image, embedded jpg) are
properly discovered.

The "problem" is therefore the heuristics because as I explained in the forum,
displaying a 1600x1200 image on my screen is fine ! zoom level is 92%

If we're going to keep the heuristics to take the decision, then maybe we
should look at the size of the preview area instead of looking at the entire
screen resolution ?
On my system, where digikam is always maximized, that area is roughly 1700x1100
...

It also makes sense if you are not using digikam in maximized mode, what's the
point in looking at the entire screen size if we don't have access to it :/

Looking forward to hearing your thoughts !

-- 
You are receiving this mail because:
You are the assignee for the bug.