[Digikam-devel] Review Request 109298: Adding photo informations to the album view item

[Albert Astals Cid]

> On mar. 18, 2013, 10:28 p.m., Gilles Caulier wrote:
> > Marco,
> > 
> > Any progress here ?
> > 
> > Gilles Caulier
> 
> Marco Berghoff wrote:
>     Not yet, much work and holiday not before mid of April. Meanwhile you can integrate r2, because it is independent of the overlay stuff.
>     
>     What do you think of my comment?
>     
>     Marco
> 
> Gilles Caulier wrote:
>     >You're right, the overlay bloat the GUI, but it is acceptable for few information.
>     >* Most of the photos are landscape so that there are some space on the top. 
>     
>     yes, but the model view is not designed to optimize space in this condition. In fact the new list view mode where work Micheal will respond to your whishes
>     
>     >* The shortcut and toolbar icon is there for switch on / off the overlay. I need this also.
>     
>     Why not... but see my next comment.
>     
>     >* The tool tips shows information only for one photo, so you cannot compare them.
>     
>     Right. But new list view mode do it very well. You can now customize all column with info that you need, taken from digiKam, metadata or file properties. This is definitively the best way to compare and sort images, better than overlay.
>     
>     >* The new table view is good for comparison of information but it has one drawback: you only have a few photos on the side.
>     
>     I'm not agree. As you can also change thumbnails size in this mode, you can extend the visible counts of item on the screen. Problem is the same with icon-view in fact. This is why you need to scroll-down.
>     
>     
>     But definitively, compare items properties will be more simple with table view than overlay : properties will be show side by side using columns.
>     
>     Gilles Caulier
>     
>     
>
> 
> Albert Astals Cid wrote:
>     Janitorial Question: What's the status of this? Has it been commited? Or not? Or there's still work to do? If there is still work to do maybe makes sense discarding this review request and starting a new one?

No answer in a year, i guess noone really cares. I'll discard it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109298/#review29479
-----------------------------------------------------------


On mar. 12, 2013, 11:10 p.m., Marco Berghoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109298/
> -----------------------------------------------------------
> 
> (Updated mar. 12, 2013, 11:10 p.m.)
> 
> 
> Review request for Digikam and Gilles Caulier.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> This patch adds a line with informations about aperture, exposure time, ISO sensitivity and focal length between filename and title. It looks like "F7.1 1/900s ISO 200 8mm".
> 
> A checkbox for switching this line on/off is added to the albumview setup dialog.
> 
> 
> Diffs
> -----
> 
>   utilities/setup/setupalbumview.cpp f2d5e7c 
>   utilities/importui/views/importsettings.cpp 0175079 
>   utilities/importui/views/importsettings.h 1c3274e 
>   libs/widgets/itemview/itemviewimagedelegatepriv.h 8735e6a 
>   libs/widgets/itemview/itemviewimagedelegate.cpp 1a1632c 
>   libs/widgets/itemview/itemviewimagedelegate.h d1c3fd0 
>   digikam/utils/albumsettings.h 501213a 
>   digikam/utils/albumsettings.cpp b838479 
>   digikam/main/digikamui.rc f410ad7 
>   digikam/main/digikamapp_p.h 2d9f0c2 
>   digikam/main/digikamapp.cpp 290840f 
>   digikam/items/imagethumbnaildelegate.cpp d34b21e 
>   digikam/main/digikamapp.h 0286bce 
>   digikam/items/imagedelegatepriv.h 0ffa233 
>   digikam/items/imagedelegate.cpp 6dfad4f 
>   digikam/items/digikamimagedelegate.cpp 3e65a85 
> 
> Diff: https://git.reviewboard.kde.org/r/109298/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine.
> Albumview items have the infoline if the checkmark is set in the setup dialog and hide it if not.
> 
> 
> Thanks,
> 
> Marco Berghoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20140811/0f85e11f/attachment.html>