<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109298/">https://git.reviewboard.kde.org/r/109298/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On març 18th, 2013, 10:28 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marco,
Any progress here ?
Gilles Caulier</pre>
</blockquote>
<p>On març 25th, 2013, 5:57 p.m. UTC, <b>Marco Berghoff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not yet, much work and holiday not before mid of April. Meanwhile you can integrate r2, because it is independent of the overlay stuff.
What do you think of my comment?
Marco</pre>
</blockquote>
<p>On març 27th, 2013, 2:48 p.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>You're right, the overlay bloat the GUI, but it is acceptable for few information.
>* Most of the photos are landscape so that there are some space on the top.
yes, but the model view is not designed to optimize space in this condition. In fact the new list view mode where work Micheal will respond to your whishes
>* The shortcut and toolbar icon is there for switch on / off the overlay. I need this also.
Why not... but see my next comment.
>* The tool tips shows information only for one photo, so you cannot compare them.
Right. But new list view mode do it very well. You can now customize all column with info that you need, taken from digiKam, metadata or file properties. This is definitively the best way to compare and sort images, better than overlay.
>* The new table view is good for comparison of information but it has one drawback: you only have a few photos on the side.
I'm not agree. As you can also change thumbnails size in this mode, you can extend the visible counts of item on the screen. Problem is the same with icon-view in fact. This is why you need to scroll-down.
But definitively, compare items properties will be more simple with table view than overlay : properties will be show side by side using columns.
Gilles Caulier
</pre>
</blockquote>
<p>On agost 15th, 2013, 9:55 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Janitorial Question: What's the status of this? Has it been commited? Or not? Or there's still work to do? If there is still work to do maybe makes sense discarding this review request and starting a new one?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No answer in a year, i guess noone really cares. I'll discard it.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On març 12th, 2013, 11:10 p.m. UTC, Marco Berghoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Digikam and Gilles Caulier.</div>
<div>By Marco Berghoff.</div>
<p style="color: grey;"><i>Updated mar. 12, 2013, 11:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a line with informations about aperture, exposure time, ISO sensitivity and focal length between filename and title. It looks like "F7.1 1/900s ISO 200 8mm".
A checkbox for switching this line on/off is added to the albumview setup dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles fine.
Albumview items have the infoline if the checkmark is set in the setup dialog and hide it if not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utilities/setup/setupalbumview.cpp <span style="color: grey">(f2d5e7c)</span></li>
<li>utilities/importui/views/importsettings.cpp <span style="color: grey">(0175079)</span></li>
<li>utilities/importui/views/importsettings.h <span style="color: grey">(1c3274e)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegatepriv.h <span style="color: grey">(8735e6a)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.cpp <span style="color: grey">(1a1632c)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.h <span style="color: grey">(d1c3fd0)</span></li>
<li>digikam/utils/albumsettings.h <span style="color: grey">(501213a)</span></li>
<li>digikam/utils/albumsettings.cpp <span style="color: grey">(b838479)</span></li>
<li>digikam/main/digikamui.rc <span style="color: grey">(f410ad7)</span></li>
<li>digikam/main/digikamapp_p.h <span style="color: grey">(2d9f0c2)</span></li>
<li>digikam/main/digikamapp.cpp <span style="color: grey">(290840f)</span></li>
<li>digikam/items/imagethumbnaildelegate.cpp <span style="color: grey">(d34b21e)</span></li>
<li>digikam/main/digikamapp.h <span style="color: grey">(0286bce)</span></li>
<li>digikam/items/imagedelegatepriv.h <span style="color: grey">(0ffa233)</span></li>
<li>digikam/items/imagedelegate.cpp <span style="color: grey">(6dfad4f)</span></li>
<li>digikam/items/digikamimagedelegate.cpp <span style="color: grey">(3e65a85)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>