[Digikam-devel] compatibleWithAdobeRGB1998.icc not getting installed

[Gilles Caulier]

By this commit in libkdcraw :

https://projects.kde.org/projects/kde/kdegraphics/libs/libkdcraw/repository/revisions/9dd63d545e699a36c24da7f7951ae61483bee35d

You can see that adobergb icc profile have been removed from libkdcraw
install. If i remember, it due to prevent duplicates icc files on
computer. Adobergb can be installed through a dedicated package
normally.

Gilles Caulier

2013/11/19 bradford powell <bradford.powell at gmail.com>:
> I think compatibleWithAdobeRGB1998.icc is supposed to be installed in
> /usr/share/kde4/apps/libkdcraw/profiles/ when digikam is installed.
>
> core/libs/dimg/filters/icc/iccprofile.cpp looks for it there (if there is
> not the official AdobeRGB1998 profile somewhere?), and when it doesn't find
> it, files with AdobeRGB colorspace are treated as though there is no
> colorspace encoded in the file (ans they look desaturated)
>
> I'm not sure if the digikam-libkdcraw should be changed so that this file is
> installed, or if iccprofile.cpp should be changed to look elsewhere for an
> AdobeRGB (or compatible) profile.
>
> CMakeLists in extra/libkdcraw/profiles only installs files that match *.icm,
> I suggest the following:
>
>
> diff --git a/profiles/CMakeLists.txt b/profiles/CMakeLists.txt
> index 7767115..4af3222 100644
> --- a/profiles/CMakeLists.txt
> +++ b/profiles/CMakeLists.txt
> @@ -23,6 +23,7 @@
>  # ============================================================
>
>  FILE(GLOB icmfiles *.icm)
> +FILE(GLOB iccfiles *.icc)
>
> -INSTALL(FILES  ${icmfiles}
> +INSTALL(FILES  ${icmfiles} ${iccfiles}
>          DESTINATION ${DATA_INSTALL_DIR}/libkdcraw/profiles )
>
>
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>