[Digikam-devel] Review Request 113519: Very draft implemetation of External Tools feature for BQM

Yuri Samoilenko kinnalru at gmail.com
Sun Nov 10 09:30:49 GMT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 10, 2013, 9:30 a.m.)

Review request for Digikam.


Storing/restoring settings through WorkflowMngr implemented.

1. renaming, batch processing without ExtenalTools
 - one queue
 - two queues
 - using multiple cores

2. renaming, batch processing with ExtenalTools
 - one queue
 - two queues with diffrent external tool
 - using multiple cores

BUG: "Target Album" in Target tab is not working in master branch(without ET) when two or more queue present - all processed pictures puts in last selected album.

Repository: digikam


It is my first review. I have some questions about direction of my work.

The core of the patch in moving Queue processing internals out of overburdened QueueMgrWindow to simple QueueMgr.
QueueMgr responsible for procession only one queue from begining to the end. To implement "group-file-passing-to-extrenal-tool" QueueMgr intercept all signals from underlying taksk and and composing "result url list" which will be sended to external tool in the end.

Configuring of External Tools impemented in new tab in BQM QueueSettings and selecting tool for current processing int "Target" tab in BQM QueueSettings.
There is no interaction within "External Tools" and "Target Album" in Target tab yet.

Any comments?

Diffs (updated)

  utilities/queuemanager/CMakeLists.txt 910752c 
  utilities/queuemanager/main/etrunner.h PRE-CREATION 
  utilities/queuemanager/main/etrunner.cpp PRE-CREATION 
  utilities/queuemanager/main/etwidget.h PRE-CREATION 
  utilities/queuemanager/main/etwidget.cpp PRE-CREATION 
  utilities/queuemanager/main/etwidget.ui PRE-CREATION 
  utilities/queuemanager/main/queuemgr.h PRE-CREATION 
  utilities/queuemanager/main/queuemgr.cpp PRE-CREATION 
  utilities/queuemanager/main/queuemgrwindow.cpp 8cd65bd 
  utilities/queuemanager/main/queuemgrwindow_p.h 7bf44da 
  utilities/queuemanager/manager/queuesettings.h 522c46f 
  utilities/queuemanager/manager/task.cpp d825380 
  utilities/queuemanager/manager/workflowmanager.cpp f7da540 
  utilities/queuemanager/views/queuesettingsview.cpp d9b89b3 

Diff: http://git.reviewboard.kde.org/r/113519/diff/



Yuri Samoilenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20131110/1ee8d8ba/attachment.html>

More information about the Digikam-devel mailing list